Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion funclip/videoclipper.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def recog(self, audio_input, sd_switch='no', state=None, hotwords="", output_dir
logging.warning("Input wav shape: {}, only first channel reserved.".format(data.shape))
data = data[:,0]
state['audio_input'] = (sr, data)
if sd_switch == 'Yes':
if str(sd_switch).lower() == 'yes':
rec_result = self.funasr_model.generate(data,
return_spk_res=True,
return_raw_text=True,
Expand Down
48 changes: 48 additions & 0 deletions tests/test_cli_sd_switch.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import sys
from pathlib import Path

import numpy as np

sys.path.insert(0, str(Path(__file__).resolve().parents[1] / "funclip"))

from videoclipper import VideoClipper, get_parser


class RecorderASR:
def generate(self, data, **kwargs):
self.return_spk_res = kwargs["return_spk_res"]
return [{"text": "", "raw_text": "", "timestamp": [], "sentence_info": []}]


def _speaker_requested(sd_switch):
model = RecorderASR()
clipper = VideoClipper(model)
clipper.lang = "zh"
_, _, state = clipper.recog((16000, np.zeros(160)), sd_switch=sd_switch)
return model.return_spk_res, "sd_sentences" in state


def test_cli_yes_enables_speaker_diarization():
args = get_parser().parse_args([
"--stage", "1",
"--file", "placeholder.wav",
"--sd_switch", "yes",
])
assert _speaker_requested(args.sd_switch) == (True, True)


def test_cli_no_and_default_keep_speaker_diarization_disabled():
parser = get_parser()
explicit = parser.parse_args([
"--stage", "1",
"--file", "placeholder.wav",
"--sd_switch", "no",
])
default = parser.parse_args(["--stage", "1", "--file", "placeholder.wav"])
assert _speaker_requested(explicit.sd_switch) == (False, False)
assert _speaker_requested(default.sd_switch) == (False, False)


def test_existing_ui_case_variants_remain_supported():
assert _speaker_requested("Yes") == (True, True)
assert _speaker_requested("No") == (False, False)