Repository navigation
test(runtime): keep native HTTP probe at a stable path - #304
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled native HTTP probe previously received a new temporary pathname on every test run, preventing path-based executable approvals from being reused.
Write only the compiled executable to
test/native-http-probe/probe(probe.exeon Windows) and create its parent directory before compilation. Keep temporary script cleanup, compilation/signing, runtime selection, and all HTTP assertions unchanged. The existing/test/ignore rule covers the output.Validation:
pnpm exec vp check: passed with two existing warnings.BAILIAN_TEST_BUNoverride.git diff --check: passed. The full repository suite was not rerun.The installed Bun remains 1.3.12. Its existing macOS binary-signing failure is outside this change; the same compiled artifact also fails signing at the original temporary location.
Approval retention duration depends on the endpoint security policy and has not been verified over 14 days. Independent simultaneous invocations of this test in one checkout share the output path.