Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
floorsjob the org standard requires (standard.md §7), following modern-di-fastapi#56, and fixes the two floors it caught.1. The asyncpg band was too coarse
The existing comment has the right idea and the wrong boundary.
asyncpgships nocp312wheel before 0.29.0 either, andasyncpg>=0.28; python_version < '3.13'covers 3.12:Split at every interpreter where upstream actually added a wheel — 0.29.0 for
cp312, 0.30.0 forcp313, 0.31.0 forcp314:2. The SQLAlchemy floor was untestable
sqlalchemy[asyncio]>=2.0.18is not a claim this repo can stand behind.advanced-alchemyis in the dev group, and every advanced-alchemy release ever published requiressqlalchemy>=2.0.20— 0.1.0 already did. The suite could never have run against 2.0.18.Left alone this is worse than a wrong floor, because the job would have looked right: it silently resolves 2.0.20 and reports the 2.0.18 claim as verified. Raised to what the tests actually exercise:
"sqlalchemy[asyncio]>=2.0.20; python_version < '3.13'",The 2.0.31 bound from 3.13 up is unchanged and correct — verified, it is what the job installs there.
Why the job exists
pytestresolves every dependency at its newest, so the bottom of each declared range ships unexercised. This job resolves direct dependencies at their floors, wheel-only, on every entry of the same matrixpytestuses, and runs the suite against them.--no-build: a floor reachable only by compiling an sdist is not a floor a user installing a wheel can reach — which matters here, since asyncpg's sdist needs a C toolchain.--no-install-projectis mandatory alongside it —--no-buildwould otherwise refuse to build this project too, and the tests import it from the checkout.The job carries the same postgres service and
DISABLE_SQLALCHEMY_CEXT_RUNTIMEhandling aspytest, for the same reasons.The dev-group floors
uv sync --resolution lowest-directtreats an unbounded name in[dependency-groups]as "any version" and resolves it to that project's first-ever release; before this the leg could not start pytest.advanced-alchemyis floored at 1 — the value is immaterial to the SQLAlchemy question above, since the>=2.0.20requirement is constant across its history.Verification
Run locally on all five interpreters at the floors, against a real postgres:
tenacity==8.4.1,sqlalchemy==2.0.20/2.0.31,asyncpg==0.28.0through0.31.0as the bands dictate, 40 passed on each. Resolved-newest path re-checked withjust install && just lint-ciand pytest at 100% coverage. Local runs are macOS/arm64; CI is the verdict on manylinux wheel coverage.