test: accept sqlalchemy 2.1 wrapping the factory's TargetServerAttributeNotMatched - #56
Merged
Merged
Conversation
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
pytestlegs of the scheduled dependency check (run 36129136224).SQLAlchemy 2.1.0 now translates asyncpg exceptions raised by an
async_creatorinto DBAPI errors. The multi-host factory's finalasyncpg.TargetServerAttributeNotMatchedtherefore reaches the caller assqlalchemy.exc.InternalError, with the asyncpg error asorig.__cause__. On 2.0 it arrives raw. The test now accepts either shape and asserts the asyncpg error is the root.TimeoutErrorandOSErrorare not translated, so the other connection-factory tests pass unchanged.Verified: the full suite passes against Postgres at 100% coverage on sqlalchemy 2.0.54 and 2.1.0;
just lint-cigreen, and ty is also clean on 2.0.54.Not in this PR: the same translation changes what
is_retriablesees for connect-time errors. That is tracked separately.