ci: pin the declared floors before installing them wheel-only - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how the
floorsjob installs, following CI6 of the standard (modern-python/.github#115). It first pins every declared floor with builds allowed (uv pip compile ... --resolution lowest-direct --no-deps), then installs those pins with--no-build, plus thedevgroup at newest.uv sync --resolution lowest-direct --no-builddoesn't fail on a floor that has no wheel for the interpreter. It skips that version and climbs to the lowest one that has a wheel, so the leg passes on a version this repo never declared. Pinning first makes the wheel-only install fail on the real floor instead. compose2pod#139 piloted this.The comments claiming
--no-buildfails on a wheel-less floor are removed, since that claim was false. The dev-group comment is removed too: dev dependencies now install at newest, so their floors no longer need to give a usable harness under a lowest resolution.