chore: give every coverage pragma a reason (TS6) - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the coverage pragmas in line with TS5 and TS6: every
# pragma: no covernow carries its reason on the same line.exclude_alsowas already exactly["if typing.TYPE_CHECKING:"]and no file is excluded, so TS5 needed no change.Counts: 0 tested / 0 deleted / 4 reasoned.
tests/test_integration.py: the phase-2handler_a2/handler_b2run only if committed offsets replay, which the test asserts never happens.tests/test_kafka_committer.py: the_drive_untiltimeout (2 lines) runs only when a test fails. A test of the test helper itself would add nothing meaningful, so the pragma stays.Local checks
just install: okjust lint-ci: passjust test-ciinside the composeapplicationcontainer against Redpanda: 216 passed, 100 % coverage