test: report a bare docs/adr/NNNN citation as unresolved - #224
Merged
Merged
Conversation
# Conflicts: # tests/test_adr_citations.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_adr_citations.pyonly matcheddocs/adr/NNNN-<slug>.md, so a citation written as a baredocs/adr/NNNNwas invisible to it. After a renumber or a drop such a citation points at whichever record holds that number next, and nothing notices.The pattern now also captures the bare form. A bare number names no file, so it falls out of the existing
is_file()check as unresolved, with no second code path. One new case in the test-of-the-test covers it, and theINVARIANT:docstring states the rule.Same change as modern-python/httpware#129; the file stays byte-identical across the org.