ci: cover 3.14t in the floors leg - #64
Merged
Merged
Conversation
`pytest` runs six matrix entries; the floors leg runs five. 3.14t is the one it omits, and wheel coverage is per-interpreter — a free-threaded build is exactly where a floor's wheel can be missing while every other entry is green, which is what §7's "every matrix entry" is for. Verified locally: the floors resolution and the suite both pass on 3.14t against the current declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #63, which landed the floors job. One line: the leg's matrix gains
3.14t.Why
standard.md §7 asks for the floors job on every entry of the same matrix
pytestuses, and that is not incidental wording — the section spells out the reason:pytesthere runs six entries; the floors leg runs five. The one it omits is3.14t, which is the entry most likely to be the odd one out: a free-threaded build is where a floor'scp314twheel can be missing whilecp314is fine and every other entry stays green. Covering five of six leaves that gap open silently — the leg passes and says nothing.Verification
In a clean worktree off
main,uv.lockdeleted before each resolve (a stale lock makesuv syncskip re-resolution and gives a false pass):Resolves wheel-only and 20 passed, on a genuinely free-threaded interpreter (
sys._is_gil_enabled()isFalse). Same for 3.13 and 3.14. So this entry is green today; it is added to keep it that way. Local runs are macOS/arm64 — CI is the verdict on manylinux coverage.What this deliberately leaves alone
The job is named
lowest; §7's job table names itfloors. That is a rename across the org, not this repo's to decide unilaterally, and it is being tracked separately — left out here so this stays a one-line change.On #62
Closing #62 in favour of this. Its diff also bounded
pydanticin[project.dependencies], and that was wrong: the failure it was reacting to came from the lint group's unboundedtyping-extensions, not from the shipped floor. uv runs one resolution across every group, so a lowtyping-extensionsholdspydanticback to a build whosepydantic-corehas no wheel for the interpreter under test. #63 fixed it at the right layer, in the group where the unbounded name actually lives.Checked directly — a clean 3.13, 3.14 and 3.14t venv each:
installs on all three, resolving
faststream==0.7.0withpydantic==2.13.5. The shipped floor was never the problem, and #62 would have constrained every user'spydanticto buy a CI-only artifact.