fix(deps): give the five unbounded dependencies a lower bound - #79
Merged
Merged
Conversation
typer, rich, semver, pydantic-settings and httpx2 were declared as bare names, so the range admitted every release ever published and semver resolved to 0.0.1, which does not build. Each floor bisected against the suite rather than guessed. Closes #78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78.
typer,rich,semver,pydantic-settingsandhttpx2were each declared as a bare name, so the declared range admitted every release ever published.semverresolved to 0.0.1, which does not build:The package did not install at its own declared minimum on any supported Python.
The floors
Each bisected against the suite, not guessed:
>=0.13>=10.2>=3>=2>=2semver2 and 3 differ substantially in API; 3.0.0 is the first release this code works against, which confirms it is written for v3.Verification
uv pip install --resolution lowest-direct .then the full suite:just lint-ciclean. Normal resolution: 481 passed.Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.