Skip to content

fix(to_geodataframe): add logic for implicit stress period data - #2852

Open
jlarsen-usgs wants to merge 5 commits into
modflowpy:developfrom
jlarsen-usgs:develop
Open

jlarsen-usgs wants to merge 5 commits into
modflowpy:developfrom
jlarsen-usgs:develop

Conversation

@jlarsen-usgs

Copy link
Copy Markdown
Contributor
  • adds support for implicit stress period data that is repeated by MODFLOW but not specified by the user. Previously to_geodataframe() would crash on user provided stress periods where explicit data was not specified in the model.

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.7%. Comparing base (556c088) to head (b506ba2).
⚠️ Report is 234 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/data/mfdatalist.py 14.2% 6 Missing ⚠️
flopy/mf6/data/mfdataplist.py 75.0% 2 Missing ⚠️
flopy/utils/rasters.py 50.0% 2 Missing ⚠️
flopy/mf6/data/mfdataarray.py 88.8% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2852      +/-   ##
===========================================
+ Coverage     55.5%    73.7%   +18.2%     
===========================================
  Files          644      659      +15     
  Lines       124135   132438    +8303     
===========================================
+ Hits         68947    97717   +28770     
+ Misses       55188    34721   -20467     
Files with missing lines Coverage Δ
flopy/mf6/data/mfdataarray.py 62.2% <88.8%> (-4.9%) ⬇️
flopy/mf6/data/mfdataplist.py 71.5% <75.0%> (-7.3%) ⬇️
flopy/utils/rasters.py 70.0% <50.0%> (-4.0%) ⬇️
flopy/mf6/data/mfdatalist.py 64.2% <14.2%> (-5.2%) ⬇️

... and 582 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant