generate more packages - #392
Merged
Merged
Conversation
Generate GWF-GNC and add it to the Gwf model. - a `node` field (a grid cell reference, e.g. GNC's cellidn) is generated as a cellid - an inline array sized by a DIMENSIONS field (GNC's cellidsj and alphasj, by numalphaj) is a fixed-width tuple column with count=<dim>, read in place, so it need not be the last column; an array of node references is a tuple of cellids - a row's cellid width, inferred from its length when there are no grid dims, accounts for several cellids per row gnc.py is generated against a spec with cellidsj marked `node`, pending the devtools change (modflow-devtools/gnc-cellid-node-refs.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- a dimension counting an array column (GNC's numalphaj) is set from the column's length unless given; a given value or differing row lengths that disagree are an error - a count may be a dimension plus or minus a constant, so EVT's pxdp and petm are tuples of nseg-1 values (numbers or time series names), and nseg is derived from them; previously rows with nseg > 2 misparsed - construct_item no longer puts an empty aux tuple into an omitted optional column before it (EVT's petm0) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…locks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- emit/consume an item's union-arm keyword after its row-key (pk/fk) columns, not after every index column (SFR `ifno DIVERSION idv divflow`) - read/write SFR's `NONE` cellid (unconnected reach) as cellid=None - ignore tokens after a block header's index in the basic and typed grammars (MAW's legacy `begin period 1 steady-state`); typed block_index gets its own rule so its LALR state doesn't merge with record rows' - drop strict xfails the aux/TAS period array work fixed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #391. Generate more packages, pull in some devtools fixes, fix some issues
gwf-gncutl-tsgwf-mawgwf-uzfgwf-hfbgwf-sfralphasjbynumalphajlen(time_series_names)nseg-1icbypackagedata.ncon(ifno)maxhfb, CSUBmaxsig0)ic): store(reach, ±1)pairs, accept raw signed ints tooauxon layer- and grid-array packages is a dict keyed by auxiliary namediversionsetc., which MF6 rejects)LISToption was written as_LIST, fix itHEAD PRINT_FORMAToverwroteHEAD FILEOUT, file records now only match rows withFILEIN/FILEOUTSTEPSwas written as floats, nowsteps: tuple[int, ...]INNER_RCLOSE,XMD)