Skip to content

feat: add NoResult to searchsidebar filter #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fryrvo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add NoResult to searchsidebar filter #8106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/ui/src/components/search/SearchSidebarFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@
</div>
</template>
</template>
<p v-if="visibleOptions.length === 0" class="offline text-center text-sm">
{{ formatMessage(messages.noResults) }}
</p>
<button
v-if="filterType.display === 'expandable'"
class="flex bg-transparent text-secondary border-none cursor-pointer !w-full items-center gap-2 truncate rounded-xl px-2 py-1 text-sm font-semibold transition-all hover:text-contrast focus-visible:text-contrast active:scale-[0.98]"
Expand Down Expand Up @@ -506,6 +509,10 @@ const messages = defineMessages({
id: 'search.filter.option.search.clear.aria_label',
defaultMessage: 'Clear search',
},
noResults: {
id: 'search.filter.option.search.no_results',
defaultMessage: 'No results found',
},
showFewer: {
id: 'search.filter.option.show_fewer',
defaultMessage: 'Show fewer',
Expand Down
3 changes: 3 additions & 0 deletions packages/ui/src/locales/en-US/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4523,6 +4523,9 @@
"search.filter.option.search.clear.aria_label": {
"defaultMessage": "Clear search"
},
"search.filter.option.search.no_results": {
"defaultMessage": "No results found"
},
"search.filter.option.search.placeholder": {
"defaultMessage": "Search..."
},
Expand Down
Loading