Make improvements to parseDSN method - #284
Open
smg6511 wants to merge 6 commits into
Open
Conversation
Refactor to simplify logic and prevent issues with trailing semi-colons in evaluated string
Add sqlite-specific parsing for parseDSN method
Prevent trying to access undefined key in foreach
Fix accessing undefined value
smg6511
marked this pull request as draft
July 31, 2026 06:40
Ok, I think I get it with sqlite now (removing extra params evaluation that's not relevant for that db type) ... sorry for all the commits.
smg6511
marked this pull request as ready for review
July 31, 2026 15:29
Ensure to initially split non-sqlite dns strings only on the first colon (allows colon use in params)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
parseDSNmethod to simplify logic and prevent issues with trailing semi-colons in evaluated string. There was an edge case in MODX where a trailing semi caused thedbnameto be blank when it was, in fact, present in the string being evaluated.