chore(mongodb-schema): update test timeout on windows and ensure close COMPASS-10932 - #854
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the mongodb-schema integration test suite to be more reliable on Windows CI and to ensure MongoDB client shutdown happens before the test cluster teardown (COMPASS-10932).
Changes:
- Increase the Mocha suite timeout to 120s on Windows to accommodate slower
mongodshutdown/data cleanup. - Register the
after()hook that closes theMongoClientbefore initializingmochaTestServer(), aiming to enforce teardown order.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nbbeeken
left a comment
There was a problem hiding this comment.
~ 35min CI is tough but at least its green
|
@nbbeeken Looking at the logs, most of it is spent downloading mongodb on windows for mongodb-runner (and the packages that use mongodb-runner). Previously there were two packages that used it and they were split between 3 and 4. Now they're both on 4 so that means they're both downloading and it takes longer. mongodb-schema is now on 3 which is why that also takes a while (but not as long). I'm going to merge this as it at least unblocks the CI passing. I'll keep the ticket open and open a pr that caches the windows mongodb download (if we can). |
COMPASS-10932
Adding this package also shuffled which tests land in which test group (1-4). mongodb-schema is in group 3. I didn't deep dive all of the failures, on the two I did look at it was 3 timing out in mongodb-schema.