Skip to content

chore(mongodb-schema): update test timeout on windows and ensure close COMPASS-10932 - #854

Merged
Anemy merged 2 commits into
mainfrom
COMPASS-10932-fix-slow-windows
Aug 13, 2026
Merged

chore(mongodb-schema): update test timeout on windows and ensure close COMPASS-10932#854
Anemy merged 2 commits into
mainfrom
COMPASS-10932-fix-slow-windows

Conversation

@Anemy

@Anemy Anemy commented Aug 13, 2026

Copy link
Copy Markdown
Member

COMPASS-10932

Adding this package also shuffled which tests land in which test group (1-4). mongodb-schema is in group 3. I didn't deep dive all of the failures, on the two I did look at it was 3 timing out in mongodb-schema.

Copilot AI lite review requested due to automatic review settings August 13, 2026 14:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the mongodb-schema integration test suite to be more reliable on Windows CI and to ensure MongoDB client shutdown happens before the test cluster teardown (COMPASS-10932).

Changes:

  • Increase the Mocha suite timeout to 120s on Windows to accommodate slower mongod shutdown/data cleanup.
  • Register the after() hook that closes the MongoClient before initializing mochaTestServer(), aiming to enforce teardown order.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nbbeeken nbbeeken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ 35min CI is tough but at least its green

@Anemy

Anemy commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

@nbbeeken Looking at the logs, most of it is spent downloading mongodb on windows for mongodb-runner (and the packages that use mongodb-runner). Previously there were two packages that used it and they were split between 3 and 4. Now they're both on 4 so that means they're both downloading and it takes longer. mongodb-schema is now on 3 which is why that also takes a while (but not as long).

I'm going to merge this as it at least unblocks the CI passing. I'll keep the ticket open and open a pr that caches the windows mongodb download (if we can).

@Anemy
Anemy merged commit 7ebd655 into main Aug 13, 2026
20 checks passed
@Anemy
Anemy deleted the COMPASS-10932-fix-slow-windows branch August 13, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants