fix(oidc pages rendering): bump compass-components version COMPASS-10980 - #855
Open
esvm wants to merge 4 commits into
Open
fix(oidc pages rendering): bump compass-components version COMPASS-10980#855esvm wants to merge 4 commits into
esvm wants to merge 4 commits into
Conversation
esvm
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @mongodb-js/oidc-http-server-pages workspace package to use a newer @mongodb-js/compass-components version so the generated OIDC login/callback pages render correctly (per the PR description).
Changes:
- Bump
@mongodb-js/compass-componentsdevDependency from^1.6.0to^1.68.0inpackages/oidc-http-server-pages.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
esvm
commented
Aug 13, 2026
| "eslint": "^7.25.0 || ^8.0.0", | ||
| "gen-esm-wrapper": "^1.1.3", | ||
| "mocha": "^8.4.0", | ||
| "mongodb-query-parser": "^4.7.16", |
Collaborator
Author
There was a problem hiding this comment.
alright without this the tests failed in the bootstrap due to this dependency being missed. Now that I added the depcheck says this is unused lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://jira.mongodb.org/browse/COMPASS-10980
Bump the version of the
@mongodb-js/compass-componentslib as this was referencing a very old instance which was causing the callback from the login page to not render properly.This issue was introduced when
leafgreen-ui/emotionwas bumped on this change.Before
After
I have tested this by manually installing a local version of this lib into compass by running:
cd packages/oidc-http-server-pages && npm packnpm install /path/to/devtools-shared/packages/oidc-http-server-pages/mongodb-js-oidc-http-server-pages-*.tgzChecklist