Add code design rules for AI - #2028
Open
stIncMale wants to merge 2 commits into
Open
Conversation
stIncMale
force-pushed
the
codeDesignRulesForAI
branch
from
August 18, 2026 22:33
cf87f28 to
9a60a44
Compare
stIncMale
marked this pull request as ready for review
August 18, 2026 22:38
|
Assigned |
Member
Author
|
@strogiyotec, please ignore the review request. The bot is too stupid and insists on its choice even after having been manually overridden. |
vbabanin
reviewed
Aug 19, 2026
| It should be created and managed either by `CommonExecutor`, `AsyncClientExecutor`, | ||
| or a class whose instance is accessible via them. This may require changing their design, implementation, documentation. | ||
| - When instantiating an executor, prefer the `MongoThreadPoolExecutor` and `MongoScheduledThreadPoolExecutor` implementations. | ||
| - Use daemon threads, see `DaemonThreadFactory`. |
Member
There was a problem hiding this comment.
Should we make this a MUST? We only spawn daemon threads, and I don’t foresee us using non-daemon threads.
Suggested change
| - Use daemon threads, see `DaemonThreadFactory`. | |
| - Must use daemon threads, see `DaemonThreadFactory`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of JAVA-6240, as discussed in stIncMale#3 (comment).
This change was reviewed using Claude. Claude was also used to explain what the change should look like.