Conversation
Whitespace-only prettier violation. Fails `prettier --check .evergreen/*.js` in run-lint-checks.sh while leaving config.yml byte-identical, so the task matrix is unchanged and the gate is the only variable. Revert before merge.
# Conflicts: # .evergreen/config.yml
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently add a lint dependency across tasks via the generator and the regenerated Evergreen config reflects that update without introducing an invalid task graph.
Pull request overview
Updates the Evergreen task graph so that all tasks depend on the run-lint-checks task (in the lint buildvariant), preventing test workloads from running when lint fails.
Changes:
- Add a post-processing step in the Evergreen config generator to append a
depends_onentry pointing torun-lint-checksfor every task. - Regenerate
.evergreen/config.ymlso tasks include the new lint dependency.
File summaries
| File | Description |
|---|---|
| .evergreen/generate_evergreen_tasks.js | Appends a cross-variant depends_on gate on run-lint-checks for all generated tasks. |
| .evergreen/config.yml | Regenerated output reflecting the new depends_on lint gate across tasks. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tadjik1
approved these changes
Sep 7, 2026
tadjik1
left a comment
tadjik1
left a comment
Member
There was a problem hiding this comment.
That's great, thanks @PavelSafronov!
tadjik1
added
the
Primary Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Gate all Evergreen tasks on the lint task, so source with lint errors never runs tests.
Notes for Reviewers
This PR has a commit that introduces a lint error. The build for that version failed quickly:
The lint error will be fixed and the full suite of tests will run. This PR is part of the testing of this task.
What is the motivation for this change?
Lint errors should prevent expensive tests from running unnecessarily.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript