Skip to content

feat: add AlwaysStdout option to output messages to stdout regardless of exit code - #10

Merged
kazeburo merged 3 commits into
mainfrom
feat/always-stdout
Aug 14, 2026
Merged

feat: add AlwaysStdout option to output messages to stdout regardless of exit code#10
kazeburo merged 3 commits into
mainfrom
feat/always-stdout

Conversation

@kazeburo

@kazeburo kazeburo commented Aug 14, 2026

Copy link
Copy Markdown
Member

PR Type

Enhancement


Description

  • Add AlwaysStdout output-routing option.

  • Derive version commit hashes from build metadata.

  • Update internal runner results and documentation.


Diagram Walkthrough

flowchart LR
  Options["Flagrun options"] 
  Output["Run message output"]
  BuildInfo["Go build metadata"]
  Version["Version commit display"]
  Options -- "enables AlwaysStdout" --> Output
  BuildInfo -- "derives revision" --> Version
Loading

File Walkthrough

Relevant files
Enhancement
flagrun.go
Add stdout routing and build commit detection                       

flagrun.go

  • Add AlwaysStdout() to route Run messages to stdout regardless of exit
    code.
  • Return the configured Flagrun instance from internalGo for output
    routing.
  • Derive abbreviated commit hashes and dirty state from Go build
    metadata.
  • Use the detected commit value in version output by default.
+39/-10 
Tests
flagrun_test.go
Update tests for internal runner return value                       

flagrun_test.go

  • Update internalGo callers for its returned Flagrun instance.
  • Assert that successful internal runs provide a non-nil configuration.
+5/-3     
Documentation
README.md
Document always-stdout output option                                         

README.md

  • Document flagrun.AlwaysStdout() and its output behavior.
+1/-0     

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit b636f40)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Comment thread flagrun.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit cff500a

Comment thread flagrun.go Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit b636f40

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@kazeburo
kazeburo merged commit 65db897 into main Aug 14, 2026
3 checks passed
@kazeburo
kazeburo deleted the feat/always-stdout branch August 14, 2026 12:39
@github-actions github-actions Bot mentioned this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant