Repository navigation
docs(agents): rely on quest context for shared rules #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6e527c8
docs(agents): rely on quest context for shared rules
kixelated ccb4e5f
chore(quest): sync the skill stubs with the pinned quest
kixelated 2ba4861
docs(agents): run only quest context before any work
kixelated 2d36677
Merge remote-tracking branch 'origin/main' into merge/215
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| name: quest-complete | ||
| description: Decide which open PRs to merge, then merge them in parallel. | ||
| description: Decide which open PRs to merge, then queue them. | ||
| --- | ||
|
|
||
| Run `quest skill complete` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. | ||
| If `quest` is not installed, follow https://github.com/moq-dev/quest/blob/main/SETUP.md first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: quest-grill | ||
| description: Settle open decisions through an interactive interview with the user. Use when the user invokes /quest-grill or wants unsettled thinking challenged before action. | ||
| --- | ||
|
|
||
| Run `quest skill grill` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/moq-dev/quest/blob/main/SETUP.md first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| name: quest-merge | ||
| description: Merge a quest once reviews and CI pass. | ||
| description: Queue a PR to land, running /quest-iterate first when it needs work. | ||
| --- | ||
|
|
||
| Run `quest skill merge` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/kixelated/quest/blob/main/SETUP.md first. | ||
| If `quest` is not installed, follow https://github.com/moq-dev/quest/blob/main/SETUP.md first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: quest-review | ||
| description: Review a PR's branch locally with the other vendor's model, then mark it ready for review. | ||
| --- | ||
|
|
||
| Run `quest skill review` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/moq-dev/quest/blob/main/SETUP.md first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: quest-unblock | ||
| description: Walk the maintainer through every quest and draft PR waiting on them, and clear waits that have resolved. | ||
| --- | ||
|
|
||
| Run `quest skill unblock` and follow its output. | ||
| If `quest` is not installed, follow https://github.com/moq-dev/quest/blob/main/SETUP.md first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,15 @@ | ||
| Read `README.md` for the three sites (moq.dev, moq.pub, moq.watch), setup, and the broadcast URL scheme. | ||
|
|
||
| # Required | ||
| # Rules | ||
|
|
||
| - Dig into the root cause and fix it at the source. Never work around a fixable bug with a retry, sleep, or timeout. | ||
| - Fail loud and early. Error on unsupported or malformed input rather than warn and continue. | ||
| - Reproduce bugs before fixing them. Land each fix with a regression test that fails without it, when one is easy. | ||
| - Keep the PR focused. No unrelated refactors, formatting churn, or drive-by changes; split when in doubt. | ||
| - Refactor aggressively for long-term maintainability, but re-evaluate the direction as you learn. | ||
| - Propose a course change, even suggest abandoning a PR, rather than finish a half-solution. | ||
| - When a decision is the maintainer's (design, copy, naming, scope), ask with 2-3 options and a recommendation. | ||
| - Never deploy to any environment, including staging, without the user's explicit permission for that deployment. A coding task or quest does not authorize a deploy. | ||
| - Protocol, player, and publisher fixes belong upstream in moq-dev/moq (`@moq/publish`, `@moq/watch`, ...). Fix them there first, then bump the `moq` submodule here; the `@moq/*` packages build from it. | ||
| - Never edit an `AGENTS.md`, `PROMPTING.md`, or skill without being prompted. Read `PROMPTING.md` before editing one or instructing other agents via context, memory, plans, or reviews. | ||
| - No em dashes in code, comments, or agent-written prose. | ||
| - Match the existing conventions, patterns, and naming when possible. | ||
| - Fix any outdated docs and comments inline; don't add a separate PR for it. | ||
| - Add the AI marker `(Written by <model>)` to any posts on GitHub, excluding commit messages that contain `Co-Authored-By:` trailers. | ||
| - Any AI comments may be challenged, and not confused with human maintainers. | ||
|
|
||
| # Guidelines | ||
|
|
||
| - Comments should explain the non-obvious why, and never the history. | ||
| - Inline simple helpers. | ||
| - Question whether functionality is needed at all before adding it. | ||
| - Deleting code is better than adding code. | ||
| - Prefer the simple solution. | ||
| - New dependencies use the newest stable version. | ||
| - Say it once, in the fewest words that hold up. | ||
| - Suggest follow up sessions and quests when finished, interactively prompting the user. | ||
| - Prefer a quest over a GitHub issue for work needing durable scope. | ||
| - Try to do stuff asynchronously. ex. ask about follow-ups while checks run. | ||
| - If the core problem is addressed, ship it instead of spinning your wheels on meaningless revisions. | ||
|
|
||
| # Development | ||
|
|
||
| PRs target `main`. Before starting, `git fetch origin` and set the upstream to the base branch. | ||
| `git stash` is one stack shared by every worktree; set work aside with a commit instead. | ||
| Use the Nix dev shell (direnv, or `nix develop --command just ...`) so tooling matches CI. | ||
| PRs target `main`. | ||
| Run `just fix` before committing. `just check` alone is not verification: look at the change in the dev server (`just dev`, `just dev-pub`, or `just dev-watch`). | ||
| Hand-drawn art ships as SVG: `just trace` the drawn PNG, compare the two, then commit only the SVG. | ||
| Quests: before starting work, run `quest guide` and follow it. The `quest` binary comes from the kixelated/quest flake input and serves the quest skills; change them upstream and bump the input. | ||
|
|
||
| Quests: before any work, run `quest context` and follow it. | ||
| The `quest` binary comes from the moq-dev/quest flake input and serves the quest skills; change them upstream and bump the input. | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.