Skip to content

Fix missing spaces in the landing page standards paragraph - #222

Merged
kixelated merged 1 commit into
mainfrom
fix/landing-page-whitespace
Nov 7, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/landing-page-whitespace

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Astro strips newline whitespace beside inline elements in the landing page's standards paragraph, joining words such as later.MoQ, IETFas, and shipmoq-lite. Preserve all four separators with explicit spaces.

Add a regression test against the rendered landing page. It fails on the original paragraph and passes with the fix.

Validation: just fix, just check, just test (57 tests), astro build --mode live, and desktop/mobile checks of the running dev server. The production HTML also preserves all four spaces.

(Written by GPT-6.1 Sol with xhigh)

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The standards paragraph adds explicit whitespace separators after the heading, the IETF-standardization statement, “We ship,” and the moq-transport link. A new integration test starts an Astro development server, fetches the landing page, checks the response status, and verifies the normalized paragraph text.

Merge Risk: Minimal · up to 30cfb

The paragraph spacing fix has focused regression coverage. No actionable issue remains that should prevent merging after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly describes the landing page spacing fix.
Description check Passed The description covers the spacing fix and its regression test.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f3e68569-db71-4352-84b1-57e32349b736
Commits

Reviewing files that changed from the base of the PR and between f849d9f and 30cfbaf.

Files selected for processing: 2

  • src/lib/landing.test.ts
  • src/pages/index.astro

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kixelated
kixelated merged commit b20ae16 into main Nov 7, 2026
3 checks passed
@kixelated
kixelated deleted the fix/landing-page-whitespace branch November 7, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant