Skip to content

docs(agents): state the squash merge method and review policy - #223

Merged
kixelated merged 1 commit into
mainfrom
docs/merge-policy
Nov 8, 2026
Merged

kixelated merged 1 commit into
mainfrom
docs/merge-policy

Conversation

@kixelated

@kixelated kixelated commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Every merge agent in the last /quest-complete run tripped on two things AGENTS.md didn't say:

  • Merge method: quest merge --land defaults to a merge commit, which the repo refuses. It allows only squash.
  • Review policy: with none stated, the quest default required a review that counts. So Dependabot PRs (#219, #218, #212) stalled even though they've always been merged without one.

This adds two lines to AGENTS.md: PRs land as squash merges; a CodeRabbit or human review of the current head counts; Dependabot PRs need no review once CI passes.

Decisions

The maintainer answered (✅ chosen):

  1. Goal: AGENTS.md lines only ✅ / also enforce in GitHub.
  2. Dependabot without review: all Dependabot PRs ✅ / patch and minor only / lockfile and pin only.
  3. Whose review counts otherwise: CodeRabbit or a human ✅ / human only / leave unstated.
  4. Vehicle: direct PR ✅ / an [XS] quest.

just check passes.

Review

CodeRabbit reviewed head 90e63db: no actionable comments (summary). This PR's policy counts a CodeRabbit review of the current head.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The development guidance now requires PRs to target main and use squash merges. It states that a CodeRabbit or human review of the current head counts. Dependabot PRs do not require review after CI passes.

Merge Risk: Minimal · up to 90e63

The documentation describes the requested squash-merge policy and review requirements. No actionable merge-blocking concern remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: it adds squash merge and review policy statements to AGENTS.md. It is specific and matches the raw summary, the description, and the objectives. The conventional prefix 'do…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains the PR's purpose: it adds two lines to AGENTS.md about squash merges, the review policy, and Dependabot PRs. It also gives the maintainer decisions, the reason for the change,…
Full details: Title check

Explanation

The title names the change: it adds squash merge and review policy statements to AGENTS.md. It is specific and matches the raw summary, the description, and the objectives. The conventional prefix 'docs(agents)' fits a documentation-only change.

Full details: Description check

Explanation

The description explains the PR's purpose: it adds two lines to AGENTS.md about squash merges, the review policy, and Dependabot PRs. It also gives the maintainer decisions, the reason for the change, and a review reference. It is clearly related to the changeset, so the check passes.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22099a30-c5ff-4eaf-9755-c76d8a59c533
Commits

Reviewing files that changed from the base of the PR and between 42a5a3d and 90e63db.

Files selected for processing: 1

  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kixelated
kixelated merged commit a071663 into main Nov 8, 2026
3 checks passed
@kixelated
kixelated deleted the docs/merge-policy branch November 8, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant