Skip to content

fix: bump web-transport-iroh to 0.4 to unbreak cargo update - #1421

Merged
kixelated merged 1 commit into
mainfrom
fix/ed25519-dalek-pinning
May 18, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/ed25519-dalek-pinning

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

  • Bump web-transport-iroh from 0.3 to 0.4 (pulls in iroh 0.98 with a newer, compatible ed25519-dalek 3.0.0-pre.6).
  • Adapt SecretKey::generate() call sites in moq-native/src/iroh.rs for the new no-arg signature.

Why

The release-plz auto-generated PR (#1391) failed CI: after cargo update, the lockfile picked up the newly-released pkcs8 0.11.0 stable, which changed Error::KeyMalformed from a unit variant to a tuple variant. The transitively pulled ed25519-dalek 3.0.0-pre.1 (via iroh 0.97) still uses the old form, so it no longer compiles.

Bumping web-transport-iroh to 0.4 (iroh 0.98) constrains the lockfile to a self-consistent set: ed25519-dalek 3.0.0-pre.6 + pkcs8 0.11.0-rc.10.

I fixed this on a new branch off main rather than the release-plz branch since release-plz force-pushes its branch on every run.

Test plan

  • CI passes (will exercise just ci, including --no-default-features, --all-features, tests, and cargo publish --dry-run)

ed25519-dalek 3.0.0-pre.1 (transitively pulled in via iroh 0.97/web-transport-iroh 0.3) is incompatible with the now-released pkcs8 0.11.0, which changed Error::KeyMalformed from a unit variant to a tuple variant. release-plz's auto-generated PR (#1391) failed to build with this combination.

Bumping to web-transport-iroh 0.4 pulls in iroh 0.98, which uses the newer ed25519-dalek 3.0.0-pre.6 and constrains pkcs8 to the 0.11.0-rc series. Also adapts the iroh SecretKey::generate() call site for the new no-arg signature.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kixelated
kixelated enabled auto-merge (squash) May 18, 2026 05:59
@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cb314c76-d3e1-479c-b728-3b30d25484aa

📥 Commits

Reviewing files that changed from the base of the PR and between 517505a and bfbe849.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • rs/moq-native/src/iroh.rs

Walkthrough

This PR upgrades the web-transport-iroh workspace dependency from version 0.3 to 0.4 and adapts the codebase to accommodate the new API. The dependency version is bumped in Cargo.toml, and two calls to SecretKey::generate() in rs/moq-native/src/iroh.rs are updated to use the new API signature that does not require an explicit rand::rng() argument.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: bumping web-transport-iroh to 0.4 to fix cargo update issues. It directly reflects both the primary file modification and the motivation.
Description check ✅ Passed The description comprehensively explains the changes, provides clear motivation, and details the problem being solved with a complete test plan.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ed25519-dalek-pinning
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/ed25519-dalek-pinning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated
kixelated disabled auto-merge May 18, 2026 06:18
@kixelated
kixelated merged commit 3284207 into main May 18, 2026
1 check passed
@kixelated
kixelated deleted the fix/ed25519-dalek-pinning branch May 18, 2026 06:19
This was referenced May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant