Repository navigation
fix: bump web-transport-iroh to 0.4 to unbreak cargo update - #1421
Conversation
ed25519-dalek 3.0.0-pre.1 (transitively pulled in via iroh 0.97/web-transport-iroh 0.3) is incompatible with the now-released pkcs8 0.11.0, which changed Error::KeyMalformed from a unit variant to a tuple variant. release-plz's auto-generated PR (#1391) failed to build with this combination. Bumping to web-transport-iroh 0.4 pulls in iroh 0.98, which uses the newer ed25519-dalek 3.0.0-pre.6 and constrains pkcs8 to the 0.11.0-rc series. Also adapts the iroh SecretKey::generate() call site for the new no-arg signature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThis PR upgrades the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
web-transport-irohfrom 0.3 to 0.4 (pulls in iroh 0.98 with a newer, compatibleed25519-dalek 3.0.0-pre.6).SecretKey::generate()call sites inmoq-native/src/iroh.rsfor the new no-arg signature.Why
The release-plz auto-generated PR (#1391) failed CI: after
cargo update, the lockfile picked up the newly-releasedpkcs8 0.11.0stable, which changedError::KeyMalformedfrom a unit variant to a tuple variant. The transitively pulleded25519-dalek 3.0.0-pre.1(via iroh 0.97) still uses the old form, so it no longer compiles.Bumping
web-transport-irohto 0.4 (iroh 0.98) constrains the lockfile to a self-consistent set:ed25519-dalek 3.0.0-pre.6+pkcs8 0.11.0-rc.10.I fixed this on a new branch off
mainrather than the release-plz branch since release-plz force-pushes its branch on every run.Test plan
just ci, including--no-default-features,--all-features, tests, andcargo publish --dry-run)