Skip to content

docs(quest): plan the release audit's unowned findings - #7003

Merged
kixelated merged 1 commit into
mainfrom
claude/release-audit-quest-plan-97b555
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
claude/release-audit-quest-plan-97b555

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

An external release-to-main audit (release 6ce6794 vs main b0a0b44) listed behavior traps before the cut. Most already had owners; a few verified ones had none.

Approach

Verified each finding against main 651c30f and the quest tree, then planned only the unowned ones.

New quests:

  • quest/m1/api-audit/binding-max-delay.md [S]: a no-argument Subscription() in Dart, Swift, Kotlin, Go (and C++/moq-c, to check) sends max_delay = None (no subscriber limit). Release and Rust/JS/Python default to zero.
  • quest/m1/upgrade-guide-facts.md [XS]: upgrade.md says drafts 18 through 22 and describes capped grants. moq-cli/MIGRATE.md says MOQ_EPOCH is ignored, but startup refuses it.
  • quest/m0/interop-green/ epic: Interop has been red on every scheduled run since 2026-10-22, and Video is red too.
    • [M] a draft-18 js-native -> rust tail empty group regression (reproduce first, since 3079d47269 may have fixed it)
    • [XS] stale browser tests (renderer invalid-attribute contract, moq-transport-14 in the element version tests)
    • [XS] wire-compat remeasure for @moq/net 0.4.6

Edits:

  • time-addressing/consumers.md: prove that an HLS-only viewer starts on-demand capture once records go away.
  • release/migrate-audit.md: review the auto-trait (Sync) losses the API diff reports.

Already owned, so not re-planned: lite timestamps, watch buffer switch, HLS records removal, discovery prerequisite (api-audit/resolve), migration collapsing, perf, lite-07 recovery, and the media timestamp-gap flakes (test-flakes-2, #6990).
Rejected as contradicting settled decisions: keeping an old archive reader, and restoring OBS video-only output.

Decisions

  1. Which findings to plan? ✅ Binding max_delay default, ✅ Stale migration docs, ✅ Interop + Video green, ✅ Edit existing quests
  2. Binding default fix: Null means default / Wrappers default zero / Explicit enum. The maintainer asked instead whether None should mean infinite, distinct from Some(0). It already does in moq-net, which led to:
  3. Default for a no-argument Subscription: ✅ Zero everywhere (None stays "no limit", asked for explicitly) / None everywhere
  4. CI tracking: ✅ m0 epic, child per cause / One m0 [M] quest
  5. MOQ_EPOCH: ✅ Fix the doc (keep refusing) / Accept and ignore it
  6. Tail regression placement: ✅ Child of the CI epic / Separate m1 quest

Impact

  • Public API: none (quests only).
  • Wire: none.

Validation

  • quest check: 612 documents ok.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Bindings default to zero max delay, upgrade notes match the code, and
Interop/Video pass on main (tail regression, stale browser tests, wire
remeasure). The HLS-only demand proof joins time-addressing consumers and
the auto-trait review joins the migration audit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9ce8c5c2-3bba-465f-8ca5-89a97c03339e
Commits

Reviewing files that changed from the base of the PR and between 82f7159 and ed22ba7.

Files selected for processing: 11
  • quest/m0/README.md
  • quest/m0/interop-green/README.md
  • quest/m0/interop-green/stale-browser-tests.md
  • quest/m0/interop-green/tail-empty-group.md
  • quest/m0/interop-green/wire-compat-remeasure.md
  • quest/m1/README.md
  • quest/m1/api-audit/README.md
  • quest/m1/api-audit/binding-max-delay.md
  • quest/m1/time-addressing/consumers.md
  • quest/m1/upgrade-guide-facts.md
  • quest/m2/release/migrate-audit.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T04:47:11.917358Z ed22ba7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: ed22ba7

No actionable bugs found in this planning-only change. The direction is sound: preserve explicit unlimited subscriptions while restoring zero-delay defaults at binding boundaries, correct migration claims rather than weakening runtime validation, and reproduce the tail failure before proposing a fix. Reusing the existing HLS-demand and migration-audit quests avoids parallel ownership; separate CI children keep fixes independently verifiable.

Verification: statically reviewed the changed plans and relevant subscription/FFI/wrapper defaults, migration docs, environment validation, and wire-compat remeasurement code. These quests do not implement the fixes. I did not run quest check, bindings, browser/interop tests, or reproduce the cited historical CI failures; passing scheduled Interop and Video runs remain the epic's completion evidence.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing: CI passes, Codex reviewed with no findings, and the OpenAI review found nothing actionable. Decisions are recorded in the PR body and each quest's Plan.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 4018a32 Oct 28, 2026
10 checks passed
@kixelated
kixelated deleted the claude/release-audit-quest-plan-97b555 branch October 28, 2026 07:00
kixelated added a commit that referenced this pull request Oct 29, 2026
main's #7003 planned the same Interop failures as quest/m0/interop-green,
so this branch's nightly/interop.md duplicated it. CONTRIBUTING already
requires re-measuring wire-compat after any publish.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant