Repository navigation
docs(quest): plan the release audit's unowned findings - #7003
Conversation
Bindings default to zero max delay, upgrade notes match the code, and Interop/Video pass on main (tail regression, stale browser tests, wire remeasure). The HLS-only demand proof joins time-addressing consumers and the auto-trait review joins the migration audit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: ed22ba7
No actionable bugs found in this planning-only change. The direction is sound: preserve explicit unlimited subscriptions while restoring zero-delay defaults at binding boundaries, correct migration claims rather than weakening runtime validation, and reproduce the tail failure before proposing a fix. Reusing the existing HLS-demand and migration-audit quests avoids parallel ownership; separate CI children keep fixes independently verifiable.
Verification: statically reviewed the changed plans and relevant subscription/FFI/wrapper defaults, migration docs, environment validation, and wire-compat remeasurement code. These quests do not implement the fixes. I did not run quest check, bindings, browser/interop tests, or reproduce the cited historical CI failures; passing scheduled Interop and Video runs remain the epic's completion evidence.
|
Landing: CI passes, Codex reviewed with no findings, and the OpenAI review found nothing actionable. Decisions are recorded in the PR body and each quest's Plan. (Written by Claude Opus 5.5) |
main's #7003 planned the same Interop failures as quest/m0/interop-green, so this branch's nightly/interop.md duplicated it. CONTRIBUTING already requires re-measuring wire-compat after any publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
An external release-to-main audit (release 6ce6794 vs main b0a0b44) listed behavior traps before the cut. Most already had owners; a few verified ones had none.
Approach
Verified each finding against main 651c30f and the quest tree, then planned only the unowned ones.
New quests:
quest/m1/api-audit/binding-max-delay.md[S]: a no-argumentSubscription()in Dart, Swift, Kotlin, Go (and C++/moq-c, to check) sendsmax_delay = None(no subscriber limit). Release and Rust/JS/Python default to zero.quest/m1/upgrade-guide-facts.md[XS]:upgrade.mdsays drafts 18 through 22 and describes capped grants.moq-cli/MIGRATE.mdsaysMOQ_EPOCHis ignored, but startup refuses it.quest/m0/interop-green/epic: Interop has been red on every scheduled run since 2026-10-22, and Video is red too.empty groupregression (reproduce first, since 3079d47269 may have fixed it)moq-transport-14in the element version tests)@moq/net0.4.6Edits:
time-addressing/consumers.md: prove that an HLS-only viewer starts on-demand capture once records go away.release/migrate-audit.md: review the auto-trait (Sync) losses the API diff reports.Already owned, so not re-planned: lite timestamps, watch buffer switch, HLS records removal, discovery prerequisite (api-audit/resolve), migration collapsing, perf, lite-07 recovery, and the media timestamp-gap flakes (test-flakes-2, #6990).
Rejected as contradicting settled decisions: keeping an old archive reader, and restoring OBS video-only output.
Decisions
Noneshould mean infinite, distinct fromSome(0). It already does in moq-net, which led to:Impact
Validation
quest check: 612 documents ok.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)