Repository navigation
Conversation
Quest-Claim: bbb59a375d762ff7
… fixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
Collaborator
Author
|
Closing as done elsewhere: both security fixes reached (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
releasestill has two security bugs fixed onmain. On WebTransport and WebSocket, a SETUP Path can override the request URI (moq-dev/moq#7206). Persisted iroh keys are written readable by everyone (moq-dev/moq#7213). This PR holds the claim on quest/m0/backport-security-fixes.md.Approach
Like earlier backports, the code lands in a separate PR against
release: moq-dev/moq#7389. It ports both fixes with their tests, passesjust ci check/just ci testagainstorigin/release, and changes no published API. Codex's local review reported no findings. Its body lists the choices made without asking. The main one: an empty SETUP Path is still accepted on URI bindings, since refusing it would need new moq-net API.This PR only records #7389 (now merged) in the quest's Plan. After the patch release publishes, it should delete the quest and its m0 link, as moq-dev/moq#6958 did.
Decisions needed
Merge moq-dev/moq#7389 intoSettled 2026-10-30: the maintainer approved it, and it merged intorelease.releasewith no version bump and no release cut.release. The maintainer picks versions by hand at that cut. Nothing to decide here until then.Combined cut contents (maintainer, 2026-10-30):
groupDuration, shipping as@moq/publish0.5.5 (landing).quest/m0/backport-release-hardening.mdfrom moq-dev/moq#7406.moq-rs0.5.2 and Dartmoq0.1.1 (moq-dev/moq#6634). Python publishes through themoq-ffi-v0.4.20tag once moq-dev/moq#7421 is onrelease. Themoq-dart-v0.1.1tag is pushed during the cut.After that combined release publishes, rerun
/quest-iteratehere to delete the quest and mark this PR ready.Impact
Validation
quest check --base origin/mainpasses.Review
Skipped: this PR changes only the quest Plan text. The code change is reviewed in moq-dev/moq#7389.
Follow-ups
mainand is not in this quest's Plan. Once it merges, consider areleasebackport through/quest-plan.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code