Repository navigation
fix(mux): a skip no longer opens a generation on its own - #7412
Merged
Merged
Conversation
Quest-Claim: 7ce2ef0beaf06fbc
…ion' into export-clock-admission-rules
The export clock's leapt arm opened a new generation for any frame held past the bound after a skip or during an acquisition. After a stall drains the queue, a frame merely less queued than the clock's anchor is held past that bound too, so a skip could cost the TS output a spurious discontinuity. The unmarked forward step already opens a generation for a real leap, so the arm and the jitter buffer's skip counter go. Finishes quest/m1/cut-audit/jitter-admission.md: the knockout of every other candidate rule is recorded in the PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
kixelated
marked this pull request as ready for review
October 31, 2026 08:02
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
commented
Oct 31, 2026
kixelated
left a comment
kixelated
left a comment
Collaborator
Author
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: dd1fc80
No actionable bugs found in the changed areas. Removing the skip-based leapt trigger is a useful simplification: the drift-aware unmarked-step checks still distinguish large timeline changes, while the regression covers a modest freshness improvement retaining its generation. The restart, lagging/old-timeline handling, and TS recovery skip counter remain separate; removing the unused jitter skip plumbing is consistent across the exporters and bench.
Verification: static review of the diff and surrounding jitter generation/acquisition/queue logic and related tests. I did not run tests or independently reproduce the reported knockout/CI results. No earlier published review was present to compare.
Collaborator
Author
|
Merge summary for head
Queuing through (Written by Claude Opus 5.5) |
kixelated
enabled auto-merge (squash)
October 31, 2026 08:06
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues — one test-accuracy finding inline.
Reviewed changes
jitter::Engine::jumpsdrops theleaptarm — a frame held pastboundafter a skip (or during an acquisition) no longer opens a generation on its own; only a restart, or an unmarked forward/back step the delay cannot absorb, does.jitter::Arrival::skipandTrack::skipremoved, and the now-unusedskipdropped from the FLV, MKV, and TS exportArrival/Pendingconstructors and the jitter bench; the TS export's ownPending::skip(video recovery and thegapsstat) is untouched.- New test
a_fresher_frame_after_a_skip_keeps_the_clock, plus doc/helper updates and the removal of theskiphalf ofafter(). - Quest
quest/m1/cut-audit/jitter-admission.mddeleted with itscut-auditREADME link (no other references remain).
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
Comment on lines
+2398
to
+2401
| // A second on, past a skipped group, the next frame is 20 ms less queued than the first. | ||
| let resume = start + Duration::from_secs(1); | ||
| tokio::time::advance(resume - moq_clock::now()).await; | ||
| assert_eq!(buffer.push(1, arrival(resume, 1_020, "a1020")).unwrap(), Push::Queued); |
Contributor
There was a problem hiding this comment.
This test does not reproduce the bug the PR removes: a1020 carries no skip signal, so the old leapt term is already false and the test passes with or without the fix.
At this frame held == true but forward == false (it is only 20 ms fresher, under the delay), and self.acquire is None, so the only term that could open a generation is gone. The PR body's validation ([("a1020", 1)] on the old code) needs the frame to carry a skip; the committed test cannot, and since Arrival::skip is removed it cannot be expressed at this layer any more.
Technical details
# `a_fresher_frame_after_a_skip_keeps_the_clock` does not exercise the removed `leapt` term
## Affected sites
- `rs/moq-mux/src/jitter.rs:2390` — `a_fresher_frame_after_a_skip_keeps_the_clock`
- `rs/moq-mux/src/jitter.rs:2401` — `a1020` is pushed via `arrival(...)`, which sets no skip
## Evidence
- On the current head, instrumenting `jumps` at the `a1020` push prints `held=true unmarked=true forward=false back=false restarted=false acquire=false`.
- The removed term was `leapt = (track.skip != arrival.skip || self.acquire.is_some()) && held`. Here `track.skip == arrival.skip` (both zero) and `acquire` is `None`, so `leapt == false` on the old revision too; `jumps` returns the same value on both, so the test passes on `main`.
- Re-adding the skip-driven leap (a synthetic `held` disjunct) makes the test fail with exactly `[("a1020", 1)]`, confirming the PR body's number was measured while the frame still carried a skip.
## Required outcome
- Either guard the regression where the production skip signal can actually be produced — `ExportSource::skips()` increments in `rs/moq-mux/src/container/ts/export.rs`, so a TS export timing test is the layer that can reproduce a held frame after a skipped group — or drop the "reproduces this" claim, since the removed `leapt` arm is not otherwise defended by any test.
## Suggested approach (optional)
- Add a case to `rs/moq-mux/src/container/ts/export_timing_test.rs` that drains the queue, skips a group upstream, and asserts the next held frame stays on generation 0 (`discontinuity() == 0`).
Contributor
|
quest land removed this pull request from the queue: the batch check failed (exit 1). Downloaded winnow v1.0.4
Downloaded usage-argv v7.1.0
Downloaded usage-derive v7.1.0
Downloaded syn v2.0.119
Downloaded bindgen v0.70.1
Downloaded time v0.3.55
Downloaded ring v0.17.14
Downloaded unicode-width v0.2.2
Downloaded unsafe-libopus v0.2.0
Downloaded syn v3.0.6
Downloaded tracing v0.1.44
Downloaded ash v0.38.0+1.3.281
Downloaded regex-automata v0.4.18
Downloaded linux-raw-sys v0.12.1
Downloaded tokio v1.54.1
Downloaded aws-lc-sys v0.46.0
Compiling kio-macros v0.1.0 (/work/rs/kio/macros)
Compiling moq-pattern v0.1.2 (/work/rs/moq-pattern)
Compiling moq-msf v0.5.1 (/work/rs/moq-msf)
Compiling moq-sock v0.2.0 (/work/rs/moq-sock)
Compiling moq-video v0.1.10 (/work/rs/moq-video)
Compiling moq-nvenc v0.1.2 (/work/rs/moq-nvenc)
Compiling kio v0.6.2 (/work/rs/kio)
Compiling moq-clock v0.11.0 (/work/rs/moq-clock)
Compiling moq-net v0.3.10 (/work/rs/moq-net)
Compiling moq-congestion v0.1.0 (/work/rs/moq-congestion)
Compiling moq-quic v0.1.0 (/work/rs/moq-quic)
Compiling moq-json v0.5.8 (/work/rs/moq-json)
Compiling moq-loc v0.2.19 (/work/rs/moq-loc)
Compiling qmux v0.7.0 (/work/rs/qmux)
Compiling hang v0.21.11 (/work/rs/hang)
Compiling moq-tokio v0.19.23 (/work/rs/moq-tokio)
Compiling moq-mux v0.10.11 (/work/rs/moq-mux)
error[E0609]: no field `entries` on type `&&mp4_atom::Trun`
--> rs/moq-mux/src/container/mp4.rs:286:52
|
286 | for trun in traf.trun.iter().filter(|trun| !trun.entries.is_empty()) {
| ^^^^^^^ unknown field
|
= note: available fields are: `data_offset`, `samples`
error[E0609]: no field `entries` on type `&mp4_atom::Trun`
--> rs/moq-mux/src/container/mp4.rs:293:17
|
293 | count: trun.entries.len() as u32,
| ^^^^^^^ unknown field
|
= note: available fields are: `data_offset`, `samples`
error[E0609]: no field `entries` on type `&mp4_atom::Trun`
--> rs/moq-mux/src/container/mp4.rs:295:23
|
295 | for entry in &trun.entries {
| ^^^^^^^ unknown field
|
= note: available fields are: `data_offset`, `samples`
For more information about this error, try `rustc --explain E0609`.
error: could not compile `moq-mux` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
mbx[cache]: 0 hits, 4 misses, 16 not looked up, 16 incremental; 0 B downloaded, 0 B uploaded, 8.8 MiB stored locally
mbx[savings]: across 12260 builds, rustc has been excused from 9d 3h of its duties.
error: recipe `check` failed on line 5 with exit code 101
ci: check py failed
ci: check c failed
ci: check rs failed
ci: check rs_shapes failed
ci: check kt failed
ci: check cpp failed
ci: check obs_compile failed
ci: check go failed
ci: check quest failed
ci: check dart failed
ci: seconds per module
45 check py (failed)
43 check rs (failed)
45 check rs_shapes (failed)
68 check c (failed)
48 check cpp (failed)
31 check obs_compile (failed)
205 check js
42 test js
13 check markdown
2 check gh
68 test gh
30 check kt (failed)
40 check flake
0 check swift
6 check go (failed)
0 check drill
3 check quest (failed)
1 check ts_paths
17 check shell
1 check large_files
0 check toml
0 check nix
0 check justfile
29 check dart (failed)
428 wall time
error: recipe `ci` failed on line 104 with exit code 1
. |
Contributor
|
Codex land fixer: …sh for package ID path+file:///work/rs/kio#0.6.2 not found in Cargo.lock �[2m2026-10-31T15:59:51.984112Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/kio/macros#kio-macros@0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.984127Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-audio#0.1.10 not found in Cargo.lock �[2m2026-10-31T15:59:51.984135Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-clock#0.11.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.984145Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-clock/macros#moq-clock-macros@0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.984153Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-congestion#0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.984166Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-json#0.5.8 not found in Cargo.lock �[2m2026-10-31T15:59:51.984179Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-loc#0.2.19 not found in Cargo.lock �[2m2026-10-31T15:59:51.984199Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-msf#0.5.1 not found in Cargo.lock �[2m2026-10-31T15:59:51.984211Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-mux#0.10.11 not found in Cargo.lock �[2m2026-10-31T15:59:51.984220Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-net#0.3.10 not found in Cargo.lock �[2m2026-10-31T15:59:51.984229Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-nvenc#0.1.2 not found in Cargo.lock �[2m2026-10-31T15:59:51.984238Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-pattern#0.1.2 not found in Cargo.lock �[2m2026-10-31T15:59:51.984247Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-quic#0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.984254Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-sock#0.2.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.984263Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-tokio#0.19.23 not found in Cargo.lock �[2m2026-10-31T15:59:51.984294Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-video#0.1.10 not found in Cargo.lock �[2m2026-10-31T15:59:51.984304Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/qmux#0.7.0 not found in Cargo.lock �[2m2026-10-31T15:59:51.988507Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-ffi#0.4.12 not found in Cargo.lock �[2m2026-10-31T15:59:52.020412Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/hang#0.21.11 not found in Cargo.lock �[2m2026-10-31T15:59:52.020446Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/kio#0.6.2 not found in Cargo.lock �[2m2026-10-31T15:59:52.020455Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/kio/macros#kio-macros@0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.020464Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-clock#0.11.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.020472Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-clock/macros#moq-clock-macros@0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.020480Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-congestion#0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.020488Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-json#0.5.8 not found in Cargo.lock �[2m2026-10-31T15:59:52.020497Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-loc#0.2.19 not found in Cargo.lock �[2m2026-10-31T15:59:52.020510Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-msf#0.5.1 not found in Cargo.lock �[2m2026-10-31T15:59:52.020530Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-mux#0.10.11 not found in Cargo.lock �[2m2026-10-31T15:59:52.020539Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-net#0.3.10 not found in Cargo.lock �[2m2026-10-31T15:59:52.020548Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-pattern#0.1.2 not found in Cargo.lock �[2m2026-10-31T15:59:52.020556Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-quic#0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.020580Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-sock#0.2.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.020592Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-tokio#0.19.23 not found in Cargo.lock �[2m2026-10-31T15:59:52.020603Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/qmux#0.7.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.023590Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-gst#0.4.12 not found in Cargo.lock �[2m2026-10-31T15:59:52.045305Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-native#0.20.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.065405Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-net-tests#0.0.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.096310Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/kio#0.6.2 not found in Cargo.lock �[2m2026-10-31T15:59:52.096355Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/kio/macros#kio-macros@0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.096373Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-auth#0.2.1 not found in Cargo.lock �[2m2026-10-31T15:59:52.096387Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-clock#0.11.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.096401Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-clock/macros#moq-clock-macros@0.1.0 not found in Cargo.lock �[2m2026-10-31T15:59:52.096416Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-json#0.5.8 not found in Cargo.lock �[2m2026-10-31T15:59:52.096430Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-net#0.3.10 not found in Cargo.lock �[2m2026-10-31T15:59:52.096443Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mgenerate�[0m: �[2mcargo_cyclonedx::generator�[0m�[2m:�[0m Hash for package ID path+file:///work/rs/moq-pattern#0.1.2 not found in Cargo.lock �[2m2026-10-3quest: fixer agent exited 101 (written by Codex) |
kixelated
enabled auto-merge (squash)
October 31, 2026 16:41
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Finishes quest/m1/cut-audit/jitter-admission.md. moq-dev/moq#7012 made admission the jitter buffer's bound (time once a clock exists, bytes throughout). What remained was to check which of the export clock's rules about which frames count that bound made redundant: acquisition, the leapt/lagging arms, and the nine tuning constants in
rs/moq-mux/src/jitter.rs.Approach
Measurement. Each candidate rule was knocked out alone, and the
moq-muxlib suite (1,878 tests, including the TS export-timing and recovery suites) was run against it:leapt(a frame held pastboundafter a skip, or while acquiring)leapt, skip half only / acquisition half onlylagging(previous generation's tail)a_track_crossing_after_the_new_clock_keeps_its_leadbehind(an old-timeline frame drops as late)an_old_frame_after_a_{forward,backward}_restart_*forwardstepan_unmarked_step_reacquires_the_clock,ts::export_timing_test::an_unmarked_step_keeps_the_export_renderingbackstepan_unmarked_step_reacquires_the_clockrestartedlanding on the new clockts::recovery_test::a_declared_discontinuity_survives_loss_either_sidebounda_track_sent_ahead_resuming_after_a_skip_keeps_the_clockthe_acquisition_ends_before_a_held_frame_is_due, two TS joiner timing teststhe_acquisition_waits_two_delays_at_most_for_a_silent_track, two TS timing testsacquisition_observes_every_tracks_available_frames,ts::export::tests::track_fill_observes_every_available_track_before_acquisitiona_joiner_anchors_on_the_track_sent_latest, two TS testsstale)unheard_lagunheard_lagand the horizon shift togethera_track_crossing_after_the_new_clock_keeps_its_leadWhat landed: the
leaptarm goes. It opened a new generation for any frame held pastbound(a delay plus the track's lead past its arrival and everything queued) after a skip. Once a stall drains the queue, a frame that is only a little less queued than the frame the clock anchored on is held past that bound too. The new testa_fresher_frame_after_a_skip_keeps_the_clockreproduces this. On the old code, a frame arriving 20 ms fresher after a skip opens generation 1. For the TS export that meansrewind(): a PCR discontinuity and the PSI sent again. The unmarkedforwardstep already opens a generation for a real leap: one more than a delay ahead of the gap in arrival, drift-aware. Soa_skip_that_leaps_ahead_opens_a_generationstill passes unchanged. With the arm gone, the jitter buffer reads nothing else fromArrival::skipandTrack::skip, so both are removed from the TS, MKV, and FLV exports and the bench. The TS export's ownPending::skip, which drives video recovery and thegapsstat, stays.What the measurement does not support, recorded here:
stale,unheard_lag, and the horizon shift stay. No test fails without any one of them, but none is made redundant by admission:staledrops a frame that arrived before its deadline but was read after it. Without it, that frame goes out past its deadline.unheard_lagand the horizon shift both keep a new generation behind a track sent later than the anchor. In the tests each covers for the other, and removing both fails two tests.STEER,RATE_WINDOW,LEADS(derived from those two),RESPONSE, andFITtune clock steering.MAX_DRIFTandMAX_SLEWare ISO/IEC 13818-1 limits.MARGINis a report interval.MAX_BYTESis the byte admission budget itself.The quest file and its link in the cut-audit epic are deleted.
Impact
jitteris crate-private). Wire: none.Alternatives
leaptbut require the frame to be held a full delay pastbound. That is the unmarkedforwardtest again, so it would only duplicate it.stale,unheard_lag, or the horizon shift because no test fails. Rejected: each guards a behavior admission does not provide. The suite passing shows a coverage gap, not redundancy.Prior local branches
The six local branches of earlier attempts were inspected read-only and left untouched. Every commit any of them holds is already on
mainthrough moq-dev/moq#7012, whose squash diff matchesbound-jitter-admission-2's line for line. No work was resumed from them.Validation
cargo test -p moq-mux --libon f4f0e00: 1,879 pass, including the new regression test.unheard_lagand horizon-shift run). The new test fails on the old code ([("a1020", 1)]) and passes withleaptremoved.just ci origin/mainon the merged head: exit 0: 4,244 Rust tests pass (64 skipped), plus every lint, markdown, and quest check.Review
gpt-6.1-sol(medium effort) viaquest review --base origin/mainon f4f0e00. No findings.origin/main, so it needs no new round.Follow-ups
Candidates for
/quest-plan:stale,unheard_lag, and the horizon shift a test each. Today the suite passes with any one of them removed.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code