Skip to content

quest: record the latency ledger decisions - #7417

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/latency-ledger-decisions
Oct 31, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/latency-ledger-decisions

Conversation

@kixelated

@kixelated kixelated commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Records the maintainer's 2026-10-30 decisions from moq-dev/moq#7372 in quest/m2/latency-ledger.md. The quest is now blocked on the two feedback reporters, so #7372's claim can be released once this merges. Quest-only change; no code, API, or wire format changes.

Decisions

  1. Sequencing.
  2. Wire shape on echo::Rendition, Echo.RenditionSchema, and ViewerRendition.
    • ✅ (a) Replace the scalar latency with latency: { jitterBuffer?, decode?, render?, device? }, with each stage in integer ms and absent when unmeasured.
    • (b) Keep a total and add stages beside it.
    • (c) Flat gauges.
  3. Which stages get exported.
    • ✅ Only jitterBuffer and device. The Goal is narrowed to match, and decode/render stay unmeasured in the harness schema.
    • Export all four.
  4. rs/hang/src/stats.rs (publisher snapshot).
    • ✅ Leave it alone, and drop it from the Plan.

Changes

  • quest/m2/latency-ledger.md: narrowed the Goal, put the four decisions in the Plan, and added the two reporters under Required.
  • quest/m2/README.md, quest/m2/stats/README.md: updated the link descriptions to the narrowed scope.
  • quest check: ok. quest unblocked quest/m2/latency-ledger.md reports it blocked by both reporters.

Follow-ups

  • Once this merges, release moq-dev/moq#7372's claim with quest start --release quest/m2/latency-ledger.md, or close it.

Review

  • Reviewer: Codex gpt-6.1-sol, medium effort (quest review --base origin/main).
  • Head reviewed: 2ec960acd195e40ce0d6ea743c05cafe46305abb.
  • Round 1: no findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Decided 2026-10-30: wait for the browser and Rust feedback reporters,
reshape echo latency as {jitterBuffer?, decode?, render?, device?} ms,
export only jitterBuffer and device, and leave publisher stats alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55af2cd4-f552-4b71-8444-6c823643af65
Commits

Reviewing files that changed from the base of the PR and between 87090bc and 29387a9.

Files selected for processing: 3
  • quest/m2/README.md
  • quest/m2/latency-ledger.md
  • quest/m2/stats/README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T19:55:02.743756Z 2ec960a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 2ec960acd195e40ce0d6ea743c05cafe46305abb.

No actionable bugs found in this documentation-only change. The direction is coherent: wait for both feedback reporters, reuse their snapshot rather than introduce a second per-player API, and limit exported measurements to jitter buffer/device while leaving publisher stats untouched. The prerequisite plans support that sequencing, and the index descriptions match the narrowed scope.

Verification: static review of the three-file diff, both reporter plans, and the existing browser probe. No tests, quest checks, builds, or live latency measurements were run; this review does not validate the future implementation or the PR's reported checks.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing: records the 2026-10-30 latency-ledger decisions (reporters added to Required, nested latency object, only jitterBuffer/device exported, rs/hang/src/stats.rs untouched). Codex review round 1 on 2ec960a had no findings; quest check passed against origin/main. After it lands, #7372's claim gets released (the maintainer chose release, not close).

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 30, 2026 20:23
@moq-bot
moq-bot Bot merged commit 19e372e into main Oct 31, 2026
6 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/latency-ledger-decisions branch October 31, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant