Repository navigation
ci: let the land gate stop just ci at the first failed module - #7466
Merged
Merged
Conversation
The host land gate ejects a failing batch whatever else fails, yet each failed batch on 2026-10-31 ran 20-50 more minutes after its first failure (check quest in 3s, check rs in 40s). CHECK_FAIL_FAST=1 stops a lane at its first failed module, cancels the running lanes, and starts no more. Without it, just ci still runs every lane to the end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Opt-in fail-fast in the dispatcher —
CHECK_FAIL_FAST=1makesrun_lanereturn at its first failed phase and the main loop setstopping, cancel the running lanes via the existingcancel, and start no further lanes; unset, every lane still runs to the end. - Cancelled lanes stay distinct from failures — the
[[ -z "$stopping" ]]guard keeps a cancelled lane's nonzero status out offailed, so only the first failure is named while cancelled phases show as(cancelled). - Tests — a parallel test proves parked
rs/cpplanes are cancelled and later lanes never start, and a serial test proves a first failure stops the run with exactly one failure line. - Comment updates —
justfileand thesh/dispatch.shheader document the new host-gate variable.
Verified locally: the full sh/dispatch-query.test.py (31 tests) passes, shellcheck sh/dispatch.sh is clean, and both new tests fail without the change (the parallel one hangs to its 60s timeout; the serial one reports two failures instead of one).
One environment note, not a code change: the two new tests need zizmor on PATH because gh is a repository-wide module selected on every diff and CI_STRICT=1 turns its absence into an error before any lane runs. That tool is present in CI's dev shell, so it only affects bare checkouts.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
This was referenced Oct 31, 2026
kixelated
added a commit
that referenced
this pull request
Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The host land gate ejects a whole batch when any module fails, yet
just cikeeps every lane running to the end. On 2026-10-31, moq's failed batches ran 20-50 more minutes after their first failure:check questin 3 s,check rsin about 40 s,test rsin 226 s. No moq PR landed between 11:27 and 16:30 while 60+ waited.Approach
CHECK_FAIL_FAST=1is an opt-in that the land gate sets.cancel, which records each one as(cancelled).just ciandjust checkstill run every lane to the end, as the dispatcher intends: one unavailable check shouldn't hide unrelated failures.CHECK_FAIL_FAST=1. That lands in kixelated/nixos#16 once this merges.Impact
Alternatives
just ci's output and kills the run at the firstci: … failedline. Rejected as a workaround for something the dispatcher should own.main.Follow-ups
quest/m0/ci/ci-fail-fast.mdfrom #7456, which is still queued. That quest is deleted once both land.Checks
python3 sh/dispatch-query.test.py: the two new tests pass, and both fail without the change. The serial one fails outright; the parked one hangs until its timeout. The existing failure and continuation tests still pass.just checkpasses.just testpasses.Review
quest review --base origin/main(Codex), round 1 on head c367838: no findings.The maintainer approved landing this past the queue with the admin bypass, since the queue it unblocks is the one it would wait in.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)