Repository navigation
quest(no-spawn): split into an epic with four children - #7519
Conversation
Quest-Claim: b045e050ea3cb96a
The maintainer accepted D1 to D5 on #7519 (2026-11-01): the quest becomes an epic whose children are the cluster's own work, admissions and stats, moq-ffi's root, and the relay's simulator tests. Each child records the decisions that belong to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pullfrog's billing service is temporarily unavailable, so this run didn't start. This is on our side, and nothing was billed. The next run should succeed; if it keeps failing, check status.pullfrog.com. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 60808005b10777d4a9b91289c1b9e5fc1053be39.
No actionable bugs found in this quest-only change. Splitting the work along ownership boundaries is clearer than one coupled implementation: cluster driving can land first, admissions build on it, and the FFI child waits for its plumbing rewrite. The original goal and explicit remaining-spawn scope are preserved; this PR changes no executable behavior, public API, or wire format.
Verification: read all changed plans, checked their local link targets against the head tree, and cross-checked relevant cluster, admission, FFI, and integration-test code. No prior published review to compare. Static review only; I did not run quest check, tests, or benchmarks. The simulator prerequisites and dial-performance measurement remain work for the implementation children, not results established here.
(Written by OpenAI)

Splits quest/m1/poll-first/no-spawn.md into the epic
quest/m1/poll-first/no-spawn/with four children, as the maintainer decided. This is a quest-only checkpoint: no code changes.Summary
no-spawn.mdbecomesno-spawn/README.md. The Goal is unchanged. The Plan records the split, and lists the spawns that stay and belong to the spawn audit.mainand the decisions that belong to it:cluster.md, [L] Cluster polls its own work. It is ready now and records D2 and D5.admissions.md, [S] Admissions and stats are polled. It requirescluster.mdand records D3. moq-dev/moq#7360 merged today, so it is no longer a blocker.ffi.md, [M] moq-ffi spawns only its root. It requires Poll-native async in moq-ffi, the quest behind moq-dev/moq#7497, and records D4.sim-tests.md, [M] The relay's in-memory tests run on kio's simulator. It requirescluster.mdandadmissions.md, and notes that it may move to m2.ffi-poll-migrate.md, the Related link now points toffi.md.Decisions (maintainer, 2026-11-01)
Cluster::newreturn, and who polls it?Cluster::new(options) -> anyhow::Result<(Cluster, Driver)>, the same shape asorigin::Producer::new.Relay::runpollsDrivernext toStarted::run, andDriverturns a child's panic into an error.Started::run.Answerpolls themoq_auth::Clientrequest inline, and dropping the wait cancels it.kio::Tasksof admissions, polled byRelay::run.Backgroundaskio::Taskschildren.Background.Choices made without asking
Cluster::newcall sites, reworksDialMapandDialers, adds aDriverthat catches panics, and needs the D5 measurement.quest mvrefuses to move a quest while it is claimed, and git cannot create a child's branch (quest/m1/poll-first/no-spawn/cluster) while this PR's branchquest/m1/poll-first/no-spawnexists. I made the move by hand. Once this PR merges,quest startcan claim (a) on its own branch.ffi-poll-migrate.md. Its PR is ready for review, so I did not move it.Follow-ups (suggested)
Criticalwill still spawn ACME renewal and the web certificate reload after this epic. The spawn audit should list them. The epic README now names them.Review
Skipped under the simple-review rule: the change touches only quests.
quest check --base origin/mainpasses (646 documents ok).quest unblockedreportscluster.mdas ready and the other three children as blocked on the intended quests.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code