Repository navigation
chore(quest): complete the recorded pre-cut security audit - #7611
Conversation
Quest-Claim: 2b504d08ed93da91
Verify the landed child fixes and preserve external owners and dropped findings in the historical triage record. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
The model never responded, so Pullfrog stopped this run after 2 minutes. The request went out but nothing came back. This is usually temporary, so re-trigger to try again.
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 5ed7461.
No actionable bugs found in this quest-only change. Removing the empty epic and its milestone entry is simpler than retaining a completed work owner; the pinned triage document preserves the dropped findings and external ownership. I verified the cited implementation PRs are merged and the importer-policy quest still points to open #7468, so this cleanup does not imply those residual importer issues are fixed.
Verification: static review of the changed documents, historical triage target, related ownership record, and GitHub merge history. No tests or gates run, and no fresh security audit of the underlying implementations; the reported local gate failure is not treated as a pass.
(Written by OpenAI)
|
No actionable comments were generated in the recent review.
|
…-complete-followups main removed the completed m1 security-audit epic (#7611), so its two remaining children move to the m1 root and are linked directly from m1's Required list where the epic stood. import-metadata-policy now links the MKV leaf limits quest instead of this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Problem
The 2026-10-27 pre-cut security audit epic has no Required children left. Verify completion against current source and recorded decisions before removing it.
Approach
Remove the completed epic and its milestone link. Replace the m0 epic's live link with a pinned historical triage record, preserving the maintainer's dropped findings and external ownership. This closes the recorded audit only; it makes no new broad audit claim.
Verified on the current branch:
rs/moq-net/src/lite/setup.rs:409andietf/session.rs:546; runtimes use the shared handshake.import.rs:356streams media and skips discarded boxes;begin_metadataat line 485 bounds held metadata, andmod.rs:41bounds fragment planning. Preserve the 2026-10-31 maintainer decision accepting metadata bounds, which supersedes the earlier incremental-only plan.mkv/import.rs:360descends metadata masters, streams blocks, skips unused fields, and replaces repeated consumed fields (set, line 923). Consumed variable-size leaves remain separately owned below.rs/moq-c/src/id.rs:40wraps and skips occupied entries;bandwidth.rs,ffi.rs, and the C guide document terminal callbacks and thread safety.web.rs:419adds private/no-store and nosniff, line 1227 sets octet-stream;internal.rs:382validates Origin and socket authority.iroh.rsusessecret::load_or_create, which exclusively creates private files and validates existing opened files without following symlinks.lite/subscriber.rs:8710ties held fills to shared reader demand; the unrelated default refusal allowance is gone.metadata.ts:60schemas are passed to JSON consumers;connect.ts:740aborts fingerprint fetches and accepts exactly 64 hex characters. The any-host development path stays as decided.Also verified the separately landed provenance work moq-dev/moq#7224 and E2EE documentation moq-dev/moq#7341. Neither requires residual epic work.
Impact
Alternatives
Keep an empty epic or reopen dropped audit findings. Neither is needed: the recorded children landed, and the maintainer's keep/drop decisions still apply. No runtime changes, version bumps, or unrelated cleanup.
Follow-ups
No new follow-ups planned. Existing owners retain their scope:
quest/m1/subscribe-ranges/fill-linear.md, claimed by moq-dev/moq#7542.quest/m2/qmux-receive-lease.md; parser fuzzing:quest/m2/media-fuzz.md.CodecID,DocType, andCodecPrivatestill useAction::Read(mkv/import.rs:365-373) and growBody::Read.data(mkv/ebml.rs:274-276). The approved leaf-limits plan remains in open moq-dev/moq#7468, alongside fMP4 refusal framing (fmp4/import.rs:407-419drops the rest of the refused call). The existingquest/m2/import-metadata-policy.mdalso records that owner and policy reconciliation. These are not reported as fixed by deleting this epic. quest: plan follow-ups from the 2026-10-31 /quest-complete requeue session #7468 currently adds them under this epic's Required list, so its eventual conflict resolution must retain both quests and link them directly from m1 rather than resurrect the completed audit. That planning PR retains ownership; this PR does not edit it.quest/m0/backport-security-fixes.md.Validation
quest check --base origin/main --branch quest/m1/security-audit/README: pass, 622 documents.git diff --check: pass.quest gate just ci origin/main: fails, exit 1. Markdown, quest, shell, large-file, TOML, Nix, justfile, and GitHub workflow lints pass. The GitHub tooling test phase reachessh/rs/test-lints.test.pyand fails before its expected Clippy diagnostic because mbx cannot spawn Cargo:Argument list too long (os error 7). Existing owner: moq-dev/moq#7594. No assertion, environment, or production path was changed to hide it.just gateand runtime/interop suites were not run for this quest-only diff.Review
quest review --base origin/main --deep: Claude Code,claude-fable-5-1, medium effort, two rounds on 5ed7461118a71176a0757fadbf2fd9a4c2b76129. Round 2 reports 0 findings.Round 1 dispositions:
quest/m2/import-metadata-policy.md:26records. All original Required children landed. Its pending parent conflict and required direct m1 links are documented above; no residual is claimed fixed.Recommendation: review this completion independently of the pending importer plan and existing gate-environment owner. No maintainer API, wire, or triage decision is open here. No merge, monitoring, or follow-up planning performed.
(Written by GPT-6.1 Sol)