Repository navigation
quest: mp4-atom iloc fixed upstream; the bump finishes it - #7686
Conversation
Quest-Claim: 2d2735ba26696b3a
The fix is up for review upstream. The quest now waits on it merging, then commits the cmaf regression input with the mp4-atom bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The iloc fix merged upstream as kixelated/mp4-atom@2f19362. What remains, moving to the release and committing the cmaf input, is tracked in the mp4-atom bump, whose PR also deletes the iloc quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head fff5e66 against base 9ac02f9. No actionable findings. The quest changes preserve the release and regression-input work as explicit follow-ups, and the linked upstream fixes and reproduction match the description.
Verification: static GitHub review of the three changed documents, upstream PRs and linked reproduction. I did not run tests or independently reproduce the allocation behavior.
|
No actionable comments were generated in the recent review. WalkthroughThe documentation now tracks upstream fixes Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This quest-only PR records that the iloc bug is fixed upstream and hands the remaining moq-mux work to the mp4-atom bump. I verified the load-bearing external claims against the upstream API rather than trusting the prose:
mp4-atom-iloc.md— size[S]->[XS], Plan reworded to the finished state, and a## Waitingon the maintainer's 0.17.x release.kixelated/mp4-atom#267indeed merged on 2026-11-03 as2f19362…, returningOutOfBoundson a zero-size extent after an item's first.mp4-atom-bump.md— Goal and Plan now cover theilocinput, name the exact pathrs/moq-mux/fuzz/regressions/cmaf/mp4-atom-iloc, and Waiting requires a release containing both#264(06a532aa) and#267(2f19362). The 31-byte input decodes to the exact entry in the #7313 comment, andkixelated/mp4-atom#260is the still-openrelease v0.17.1PR whose changelog picks up both fixes.fuzz-findings/README.md— both child summaries updated consistently with the files above.
All /quest/... link targets exist, regressions/cmaf/ is correctly absent (the input is deliberately uncommitted until the bump), and no other quest references iloc.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Quest: mp4-atom iloc is bounded
Summary
The fix belongs in mp4-atom, and kixelated/mp4-atom#267 merged on 2026-11-03 as kixelated/mp4-atom@2f19362. When an item's offset, length and index sizes are all 0, its extents take no bytes, so decode now rejects any zero-size extent after the item's first one, returning
OutOfBounds. A single zero-size extent still decodes, as the maintainer decided on 2026-10-30. The pending release PR kixelated/mp4-atom#260 picks it up.This PR only rewrites quests; it does not complete the iloc quest:
mp4-atom-iloc.md: records Add support for RUST_LOG again. #267's merge and states that the remaining work is tracked in the mp4-atom bump. That remaining work is moving to the release and committing the 31-bytecmafinput. The quest's## Waitingkeeps only the outside condition: a 0.17.x release containing 2f19362. Size drops from S to XS.mp4-atom-bump.md: its Goal and Plan now cover theilocinput,rs/moq-mux/fuzz/regressions/cmaf/mp4-atom-iloc. ItsWaitingnow needs a release containing both Maybe close on disconnected element. #264 and Add support for RUST_LOG again. #267, and its PR deletes the iloc quest.fuzz-findings/README.md: updates both children's summaries.The regression input is not committed. Before the bump it would fail the merge gate, which the epic's Plan forbids.
Local verification
On
moq-muxwith mp4-atom 0.17.0, the input reproduces the bug:fuzz::tests::regressionspanics with "31 input bytes allocated 6291464 bytes in 32 allocations". I then patched in #267's branch with a temporary[patch.crates-io](not committed). With the patch,fuzz::tests::regressionsandseeds_are_acceptedpass, and so does all ofcargo test -p moq-mux(1987 passed).quest check --base origin/mainpasses on fff5e66.Decisions
The maintainer decided on 2026-11-03 to land this quest update now, rather than keep it as a draft until the bump.
Choices I made without asking, all in #267:
OutOfBounds, matching how Maybe close on disconnected element. #264 handledsgpd.I kept the iloc quest open, waiting on the release, rather than folding it into the bump and deleting it here. The bump's PR deletes it.
Review
Round 3: Codex
gpt-6.1-sol, medium effort, viaquest review --base origin/main, on fff5e66, after mergingorigin/main. No findings.Earlier rounds: round 1 raised one finding about
quest/m2/performance-survey/mkv-fragments.md. I refuted it because that file is not in this branch's diff;origin/mainhad moved during the round. Round 2 had no findings.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code