Repository navigation
chore(quest): move MoQ on rind to m1 and drop relay ACME for now - #7749
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 1f48d46 against base 759e9e1.
No actionable finding in the quest reorganization. The replacement removal quest makes the breaking feature/config change explicit, and the restored-ACME quest retains its adapter prerequisite. The corresponding rind quest move has now landed.
Static GitHub-only review; I did not run quest validation or build the relay.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
WalkthroughThe quest documents move rind migration and related transport and RTC work into m1. They describe removing relay ACME during the migration and add m3 quests for publishing the rind adapter and restoring relay ACME. Related quest links now point to the updated m1 and m3 locations. Merge Risk:
|
There was a problem hiding this comment.
ℹ️ Minor suggestions only.
Reviewed changes
- Rind epic moves to m1 —
quest/m2/rind/becomesquest/m1/rind/, its index entry moves from the m2 README to the m1 README, and every in-repo link is rewritten. - New ACME removal quest —
quest/m1/rind/acme-remove.mddrops moq-relay'sacmefeature and rustls-acme so the rind epic no longer waits on instant-acme 0.9. - ACME return quests move to m3 —
acme.mdbecomesquest/m3/relay-acme.md,instant-acme.mdbecomesquest/m3/rind-instant-acme.md, both listed in m3, with the rind adapter link repointed to its now-realquest/m3/instant-acme-publish.md.
ℹ️ An m1 quest still requires m2 work
quest/m1/rind/rtc.md requires quest/m2/webrtc/vendor.md. Now that the rind epic is in m1, a quest that must land before the next release cut depends on later-milestone work, which contradicts quest/README.md's milestone split. The PR body notes this, but it needs a decision rather than being carried: move vendor.md into m1 with the epic, or leave rtc.md in m2 so m1's rind work is landable before the cut.
Technical details
# Resolve the m1-requires-m2 dependency
## Affected sites
- `quest/m1/rind/rtc.md:33` — `Required` links `quest/m2/webrtc/vendor.md`
- `quest/m1/rind/README.md:69` — lists `moq-rtc on rind` among m1's required children
- `quest/m2/webrtc/vendor.md:1` — remains in the m2 webrtc epic
## Required outcome
- The rind epic in m1 either has no m2 prerequisite, or the prerequisite moves to m1 as well.
- If `rtc.md` stays in m1, the milestone definitions in `quest/README.md` should still make its ordering coherent.
## Suggested approach (optional)
- Moving `vendor.md` to m1 is the smaller change and matches the stated intent that rind is m1 work; otherwise move `rtc.md` back to m2 and keep only `transport.md` and `acme-remove.md` as m1 children.
## Open questions for the human (optional)
- Is the rind epic meant to be fully landable before the next cut, or is m1 only the priority bucket here?deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
Relay ACME's return quest no longer promises cache compatibility or an unchanged config, since m1 removes the feature, its config, and its cache. The transport plan no longer says relay ACME owns rustls-acme. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Reworded
quest/m1/rind/transport.mdso rustls-acme leaves with ACME removal rather than staying relay ACME's dependency. - Reworked
quest/m3/relay-acme.mdto drop the cache and config compatibility promises and to state that the returning feature re-adds theacmeflag and an ACME config section.
The remaining m1→m2 vendoring dependency is the open decision already recorded in the PR body, not a new finding.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: 91e69c7, following 1f48d46.
The follow-up removes the stale assumption that ACME and its cache survive the interim removal, and the transport quest now assigns rustls-acme removal consistently. I found no additional actionable issue in that delta. The m1-to-m2 WebRTC dependency remains a maintainer decision explicitly called out in the PR.
Verification: static GitHub inspection only; I did not run quest validation or build the relay.
(Written by review (OpenAI))
m1's moq-rtc on rind requires the vendored stack, which requires the rename, so both move to the m1 top level (maintainer, 2026-11-03). They stay children of the m2 WebRTC epic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head: 79b1df5, following 91e69c7.
The earlier m1-to-m2 dependency concern is addressed: the maintainer chose to move the WebRTC rename and vendoring prerequisites to m1, preserving their ordering and updating the in-repository links. The unrelated changes in the comparison come from the main-branch merge. No new actionable findings in this update.
Verification: static GitHub-only inspection; I did not run quest validation or build the relay.
(Written by review, OpenAI)
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Moved the WebRTC rename and vendoring quests from
quest/m2/webrtc/to the m1 top level asquest/m1/webrtc-rename.mdandquest/m1/webrtc-vendor.md, resolving the prior m1→m2 dependency. - Repointed every reference to those quests across the m1 and m2 trees, including
quest/m1/rind/rtc.md,quest/m2/p2p/native-quic.md,quest/m2/rtc-pacing.md, and the m2 webrtc children. - Added both quests to
quest/m1/README.mdbefore the rind epic and recorded the milestone shift in each quest's Plan while keeping them children of the m2 WebRTC epic.
All /quest/*.md links in the changed files resolve, and no stale m2/webrtc/rename.md or m2/webrtc/vendor.md references remain.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
|
quest land watch: the merge queue removed this pull request at 79b1df5 because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |
|
quest land watch: re-enqueued this pull request at 371658d, at the back of the merge queue, with the land fixer's fix ( (written by quest land watch) |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Merged
origin/maininto the branch and adapted main's newquest/m2/webrtc/dtls-timeout.mdso its rename and vendoring links point atquest/m1/webrtc-rename.mdandquest/m1/webrtc-vendor.md. - Kept
quest/m2/webrtc/README.mdlisting both m1-level quests alongside the new DTLS timeout quest, and left thedtls-after-ice/sdp-bandwidthchildren pointing at the m1 vendoring quest. - Confirmed no stale
m2/webrtc/rename.md,m2/webrtc/vendor.md, orm2/rind/references remain in the quest tree after the merge.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
Merge the queue fixer's 3ec3dbd (rind moved to m1 by #7749) and main. The Nightly epic lists both this PR's children and #7747's. Fold this PR's duplicate rind/crypto.md into #7747's rind/crypto-sign.md, and point miri-frame.md at m0/nightly/miri.md, where #7747 moved the Miri budget quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Problem
MoQ's switch to rind sat in m2. Its relay ACME area waited on instant-acme 0.9, which still isn't released (crates.io has 0.8.5). ACME is a recent feature nobody uses yet.
Approach
Decided by the maintainer on 2026-11-03:
quest/m2/rind/toquest/m1/rind/and lists it in m1. Links are rewritten.quest/m1/rind/acme-remove.md[S]: remove moq-relay'sacmefeature and rustls-acme until ACME returns.acme.mdtoquest/m3/relay-acme.md(ACME returns on instant-acme and rind) andinstant-acme.mdtoquest/m3/rind-instant-acme.md, both listed in m3.moq-rtc on rind(m1) required the m2 quest "Vendor and trim the stack" (raised by CodeRabbit and Pullfrog). The maintainer picked one of three ways to resolve that (2026-11-03):quest/m2/webrtc/rename.md[M] andvendor.md[L] to the m1 top level, still listed as children of the m2 WebRTC epic, like mesh-key-codec. They are now webrtc-rename and webrtc-vendor, listed in m1'sRequiredbefore the rind epic. Each records the decision in its Plan.rtc.mdback to m2 and narrow the m1 rind epic.Review follow-ups:
quest/m3/relay-acme.mdno longer assumes ACME survives the gap. It drops the promise of rustls-acme cache compatibility and says moq-relay regains theacmefeature and an ACME config section.quest/m1/rind/transport.mdno longer says relay ACME owns rustls-acme. The dependency leaves with ACME's removal.origin/mainis merged in. refactor!: merge moq-sign and moq-e2ee into moq-crypto; track::Info::rescale #7702's moq-e2ee → moq-crypto rename doesn't touch these quests. The open planning PRs moq-dev/moq#7748 and moq-dev/moq#7747 still add children underquest/m2/rind/(crypto.md,crypto-sign.md). Whichever of these lands second must move those children toquest/m1/rind/.Review
mechanical fix by codex / Codex:
Merged base, preserved the DTLS timeout requirement alongside the m1 move, and updated renamed quest links; validated with git merge --no-edit base, quest check (560 documents ok), and git diff --check base...HEAD; documentation only, no executable packages to build or test.(head 371658d)quest review), gpt-6.1-sol, medium effort.origin/main.Impact
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code