Repository navigation
fix(carla): stamp status snapshots from the broadcast clock - #7755
Merged
Merged
Conversation
Quest-Claim: 7350a1f8b5646919
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d-timestamp # Conflicts: # dart/moq/MIGRATE.md # rs/moq-ffi/MIGRATE.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d-timestamp # Conflicts: # cpp/moq/MIGRATE.md # dart/moq/MIGRATE.md # go/wrapper/MIGRATE.md # kt/moq/MIGRATE.md # py/moq-rs/MIGRATE.md # rs/moq-c/MIGRATE.md # rs/moq-ffi/MIGRATE.md # swift/MIGRATE.md
# Conflicts: # cpp/moq/MIGRATE.md # dart/moq/MIGRATE.md # go/wrapper/MIGRATE.md # kt/moq/MIGRATE.md # py/moq-rs/MIGRATE.md # rs/moq-ffi/MIGRATE.md # rs/moq-mux/src/json.rs # swift/MIGRATE.md
kixelated
reviewed
Nov 3, 2026
kixelated
left a comment
Collaborator
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head aeac7c8.
No actionable findings. The timed status track and broadcast-clock timestamp address the constructor and update mismatch introduced by #7691, and the test stub now requires the timestamp. Using the shared broadcast clock is the right direction for alignment with media.
Verification: GitHub-only static review of the CARLA change, binding contract, and tests. I did not run the checks or exercise CARLA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
moq-dev/moq#7691 made every JSON write take a broadcast-clock timestamp and refuses an untimed JSON track. It missed the in-tree CARLA status publisher:
demo/carla/sim/moq_carla_sim/publish.pystill created thestatustrack withmoq.TrackInfo(compress=True)and calledSnapshotProducer.update(payload)without a timestamp. So onmain,just checkfails atcheck carla(pyright reports the missing argument), and the worker, which installs the bindings from this checkout, would fail withTimestampMismatchat startup.Approach
statustracktimescale=1_000.StatusPublisher.publishwithmoq.media.CatalogProducer(broadcast).now(). That is the broadcast clock the bridge's video tracks are shifted onto, so status and video share one timeline.SnapshotProducer.updateto take(value, timestamp)and add aCatalogProducerstub. A call that drops the timestamp now fails the tests instead of being hidden by the stub.I searched the rest of the tree (Python, Go, Kotlin, Swift, Dart, C/C++, the interop clients, demos, and doc samples) for other JSON writers that #7691 left untimed. There are none: CARLA's
statustrack was the only one. The JS@moq/jsonpackage has its own implementation, which #7691 did not change.Impact
statustrack now carries a timescale and frame timestamps, as feat!: JSON writes take a broadcast-clock timestamp in every binding #7691 requires for every JSON track.Checks
just carla check: pyright found 0 errors, pytest passed 169 tests, and the launcher, server, systemd, and bridge GPU script tests all passed.ruff checkandruff format --checkindemo/carla/sim: clean.Review
quest review), gpt-6.1-sol, medium effort.origin/mainat 7e4ed93.(Written by Claude Opus 5.5)