You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
quest(ci): retire the stale userns mapping quest - #7763
The quest quest/m0/ci/userns-uid-map.md asked check flake to skip when a Nix builder can't write /proc/self/uid_map, and claimed that MOQ_USERNS_UNAVAILABLE doesn't catch this case. On current main that premise is false.
Approach
Retire the quest. quest rm deletes it and its entry in quest/m0/ci/README.md. Nothing else changes, and the branch carries no implementation.
Decisions
✅ Retire the quest (maintainer, 2026-11-03). Local check flake already detects a refused UID mapping and skips:
nix/runner/userns-probe.nix runs unshare --map-root-user true inside a Nix builder. That attempts the mapping write itself, and on refusal it emits MOQ_USERNS_UNAVAILABLE and exits 77.
The check:flake arm in sh/dispatch.sh runs that probe outside CI_STRICT. It matches MOQ_USERNS_UNAVAILABLE, prints a skip note, and returns 77 (skipped).
Reproduced earlier on this PR: on a host that refuses the mapping, the probe failed with unshare: write failed /proc/self/uid_map: Operation not permitted, and CHECK_MODULES=flake just check --all reported check flake (skipped).
check flake already probes the mapping write itself with
unshare --map-root-user and skips on refusal, so the quest's premise
is stale.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
quest(ci): resolve stale userns mapping scope
quest(ci): retire the stale userns mapping quest
Nov 4, 2026
No actionable comments were generated in the recent review.
Walkthrough
The CI README no longer includes the Required-list entry for the user-namespace UID-map item. The planning document describing a proposed UID-map write probe and conditional check flake skip was deleted.
Merge Risk: Minimal · up to bfdfe
This documentation-only retirement presents no identified merge-blocking risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly states that the stale user-namespace mapping quest is being retired. It matches the changeset.
Description check
The description explains why the quest is stale, identifies the removed files, and documents validation. It is directly related to the changeset.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
Finishing Touches
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 806122e5-4940-4a28-b9c8-aea737651105
Commits
Reviewing files that changed from the base of the PR and between b8e77d8 and bfdfef8.
Files selected for processing: 2
quest/m0/ci/README.md
quest/m0/ci/userns-uid-map.md
Files with no reviewable changes: 1
quest/m0/ci/userns-uid-map.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
✅ No new issues found.
Reviewed changes
Retire the userns quest — deletes quest/m0/ci/userns-uid-map.md and its entry in quest/m0/ci/README.md; no other tracked references remain.
Verified the retirement premise on the checked-out head: nix/runner/userns-probe.nix:14-16 attempts the UID mapping inside a Nix builder and emits MOQ_USERNS_UNAVAILABLE, sh/dispatch.sh:343-355 matches it and returns 77 outside CI_STRICT, and sh/dispatch-query.test.py:449 covers the skip. The two-file shape matches prior quest retirements. No public API or wire impact.
No actionable finding in retiring this quest. The builder-side unshare --map-root-user probe emits the marker on failure, and the local flake dispatcher recognizes it as a skip while strict CI still runs the lane. Verification: static GitHub inspection only; I did not reproduce the mapping failure or run the flake check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kixelated
changed the title
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
kixelated
left a comment
Problem
The quest
quest/m0/ci/userns-uid-map.mdaskedcheck flaketo skip when a Nix builder can't write/proc/self/uid_map, and claimed thatMOQ_USERNS_UNAVAILABLEdoesn't catch this case. On current main that premise is false.Approach
Retire the quest.
quest rmdeletes it and its entry inquest/m0/ci/README.md. Nothing else changes, and the branch carries no implementation.Decisions
check flakealready detects a refused UID mapping and skips:nix/runner/userns-probe.nixrunsunshare --map-root-user trueinside a Nix builder. That attempts the mapping write itself, and on refusal it emitsMOQ_USERNS_UNAVAILABLEand exits 77.check:flakearm insh/dispatch.shruns that probe outsideCI_STRICT. It matchesMOQ_USERNS_UNAVAILABLE, prints a skip note, and returns 77 (skipped).unshare: write failed /proc/self/uid_map: Operation not permitted, andCHECK_MODULES=flake just check --allreportedcheck flake (skipped).Impact
Validation
quest check --base origin/mainpasses (562 documents ok).CHECK_MODULES=markdown just checkpasses.Review
quest review(Codex gpt-6.1-sol, medium) atbfdfef8388reported 0 findings.Follow-ups
None.
(Written by Claude Opus 5.5)