[kixelated]

Problem

The sampler lifetime fixture ran on macOS even though it drives a Linux-only branch. Its fake generator rejected the non-Linux branch's --duration 10s argument. Reproduced on actual macOS (kixtop), matching the unchanged-main report in moq-dev/moq#7781, which only added quests.

Approach

• Restrict the sampler fixture to Linux, matching its sibling tests.
• Cover the duration-limited branch with a fake generator that requires --duration 10s, produces a throughput summary, and needs no sampler.
• Remove the completed quest and its link.

Choice made without asking: the new fixture supplies uname() = Darwin so Linux CI exercises that branch too.

Checked newer open PR file lists before claiming. moq-dev/moq#7605 is already merged; no open PR implements this fix.

Impact

• Public API and wire: no changes.
• Test-only change; production code and host/service configuration are unchanged.

Validation

• Linux: quest gate just ci origin/main passed every selected module, including relay tests, benchmark compilation, tooling, and formatting.
• Linux: python3 bench/relay.test.py -v: 7 passed.
• macOS (kixtop, Nix dev shell): quest gate python3 bench/relay.test.py -v: 2 passed, 5 Linux-only tests skipped. Before the fix, the sampler fixture failed with assert '--duration' not in rest.
• quest check --base origin/main: 560 documents valid.

Review

Claude Code, Claude Opus 5.5, medium effort, via quest review --base origin/main.
Round 1 reviewed head 41c588f21e: no findings.

Alternatives

Skipping only the sampler fixture would leave the non-Linux workload path uncovered.

Follow-ups

None. No maintainer decisions remain.

(Written by GPT-6.1 Sol)

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: f0bf93b0-9646-4e64-880c-b6d249fc8be6

Commits

Reviewing files that changed from the base of the PR and between 6647cda and 41c588f.

Files selected for processing: 3

• bench/relay.test.py
• quest/m0/README.md
• quest/m0/relay-test-macos.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[pullfrog]

✅ No new issues found.

Reviewed changes

• Sampler fixture now Linux-only — test_sampler_stops_generator_after_collecting_both_processes is skipped off Linux, matching the branch it drives.
• New non-Linux branch coverage — test_generator_duration_limits_workload_without_sampler fakes uname() = Darwin, requires the --duration 10s load invocation, and asserts the resulting summary window and absence of sampler metrics. HOST_BIN=false makes an accidental Linux-branch run fail loudly rather than pass trivially.
• Quest retired — the completed quest/m0/relay-test-macos.md and its index link are removed; no dangling references remain.

Verified locally: python3 bench/relay.test.py -v passes all 7 tests including the new fixture.

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏}

[kixelated]

Automated review by review (OpenAI)

Reviewed head 41c588f.

No actionable issue found in the platform gate or the new duration-limited workload fixture. The Linux fixture now runs only where the sampler branch is used, and the new test exercises the non-Linux branch without requiring a sampler.

Verification: GitHub-only static review of the changed test and surrounding workload/summary paths. I did not run the test suite or verify the reported macOS run.

(Written by review (OpenAI))