Repository navigation
Conversation
Quest-Claim: 87090d0b26897f54
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This was referenced Nov 4, 2026
Collaborator
Author
|
Maintainer decisions (2026-11-04, /quest-unblock), superseding this PR's
(Written by Claude Opus 5.5) |
Collaborator
Author
|
Closing: both questions this draft records are already settled on (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WebRTC consolidation is still needed and was unclaimed. Implementation discovery found the private API boundary the Plan explicitly reserves for the maintainer, plus an unconditional upstream SCTP dependency that prevents the promised gateway-only build.
Approach
This is a blocked diagnostic checkpoint, not an implementation of the rename. Record both decisions in the quest's
Waitingsection and correct its registry assumptions. No production code, callers, features, versions, or wire behavior has changed. The full consolidation and migration remain on this PR after those decisions.Impact
moq-rtctomoq-webrtc, folds ICE into it, removes moq-tokio'swebrtcfeature, and migrates every consumer, doc, and quest together.moq-iceandmoq-webrtcon 2026-11-03;moq-rtcexists, with latest version 0.3.22. There is no publishedmoq-iceto retire. First publication ofmoq-webrtcremains a release-cut action after implementation, with the maintainer's version choice. This attempt publishes no registry package or release tag and bumps no version.Evidence
At discovery base
acef90cf0425d9f0e4e699759cede07adfb2ecfb:Client::connect_webrtcreads the privatemoq,versions, andtimeoutfields and private connect/runtime helpers.Listener::accept_webrtcenters private listener activity, applies the handshake deadline, and constructsserver::Requestwith private fields, including qmux limits and the deadline carried through admission. There is no public external-transport constructor. A mechanical move across crates cannot preserve that behavior.tokio::spawnwould change behavior for callers outside a Tokio runtime.[dependencies.sctp-proto]and no SCTP feature; itsRtcownsRtcSctpunconditionally. The current stable str0m 0.25.0 also listssctp-protoas non-optional and exposes no SCTP feature, so upgrading alone cannot fix it.cargo tree --locked -p moq-rtc --no-default-features -e normal,build -i sctp-protoconfirms the gateway still pullssctp-proto v0.10.5through str0m. Gating only moq-webrtc's direct data-channel code cannot remove SCTP from a gateway build.Overlap
Checked refreshed open PR titles, bodies, and branches, plus changed files for newer PRs and supplied matches before claiming. moq-dev/moq#7678 changes listing/follow callers; moq-dev/moq#7771 replaces native transport adapters; moq-dev/moq#7729 changes retention defaults. None consolidates the crates. Independent JS FETCH and relay ACME work is untouched. Transport-on-rind should account for the completed consolidation when resumed.
Alternatives
The choices below are proposals, not maintainer decisions. No public shim, raw private-field export, duplicated admission path, or partial crate migration was introduced.
Follow-ups
No separate follow-up proposed. All consolidation, coherent name migration, REMB/TIAS preservation, feature build checks, interop, and implementation review remain in this quest.
Checks
On checkpoint
f22f07b4dfcc918419ab4e49844b7b5c970ccfc0, with the repository Nix dev shell:quest gate just ci origin/main: pass (quest, Biome, shell, Markdown, text, TOML, Nix, justfile, large-file, and GitHub-tool checks/tests).quest check --base origin/main: pass, 571 documents.git diff --check: pass.--no-default-features: confirms SCTP is still mandatory.Review
Source/API and dependency audit completed locally by GPT-6.1 Sol on checkpoint
f22f07b4dfcc918419ab4e49844b7b5c970ccfc0. Implementation review has not run: implementation is blocked on the maintainer decisions below. The PR remains a draft.Waiting
(Written by GPT-6.1 Sol)