Repository navigation
fix(ci): clear Nightly dependency audit failures - #7809
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 648a4b3.
No actionable issue found. The Rust ignore is specific to the unmaintained proc macro and records its dependency path and removal condition; the Bun refresh keeps the existing overrides and consolidates the affected dependency resolutions.
Verification: GitHub-only static inspection of the advisory, dependency paths, upstream caller APIs, audit configuration and quest updates. I did not run the audits, dependency installation or tests.
(Written by review (OpenAI))
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Root Bun lock repair:
bun.lockre-resolvesglobto 14.0.3 and both nestedminimatch9.0.9 paths onto the shared 11.0.4 under the existing root overrides, moving only the glob/minimatch dependency closure. - Rust advisory suppression:
deny.tomlignoresRUSTSEC-2026-0173for build-timeproc-macro-error2, reached only throughlibcrux-intrinsics'scfg(hax)edge. - Quest bookkeeping: removes the completed nightly audits quest and its README link, and updates the recurring dependency-audit notes.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Problem
Nightly's Rust audit rejects RUSTSEC-2026-0173, and the root Bun audit still resolves vulnerable glob/minimatch versions despite existing root overrides. Completes
quest/m0/nightly/audits.mdand removes its file and link.Approach
bun update glob minimatch --lockfile-only --ignore-scripts: glob 10.5.0 becomes 14.0.3 and both nested minimatch 9.0.9 resolutions join the shared 11.0.4. Only glob/minimatch and their dependency closures change. The obsolete glob CLI dependency subtree disappears; no unrelated package is upgraded.libcrux-intrinsics 0.0.9 -> core-models 0.0.7 -> hax-lib 0.3.7 -> hax-lib-macros -> proc-macro-error2. The core-models edge is enabled only undercfg(hax), so it is absent from the normal host build. The ignored crate is a build-time proc macro.Evidence
dc0bd09b1114533f325376688e0d7dc1a6394da2before editing:just rs auditfails only RUSTSEC-2026-0173;just js auditfails the root graph on the two advisories while all six standalone graphs pass.cfg(hax). hax-lib-macros 0.4.2 already drops proc-macro-error2, but core-models' 0.3 requirement cannot select it. Confirmed registry releases andcargo tree --locked --all-features --target all -i proc-macro-error2.Impact
Alternatives
A stable Rust dependency upgrade cannot remove this edge yet, and overriding hax across its incompatible 0.x range would be unjustified. For JS, the existing overrides already express the required policy; a targeted resolution is sufficient, so no additional override, ignore or parent upgrade is added.
Validation
just rs audit: pass after the change; advisory, license, ban and source policies all pass, with existing non-failing duplicate/license warnings.just js audit: all seven tracked Bun lockfiles pass.bun install --frozen-lockfile: pass, including the normal postinstall; leaves the lock unchanged.quest check --base origin/main: pass, 593 documents.git diff --check origin/main...HEAD: pass.quest gate just ci: pass on the committed tree, including all selected JS checks/tests, the docs build and TypeDoc fixtures, Markdown, and GitHub tooling checks/tests. The initial run overlapped a final notes edit and failed the Markdown mirror comparison; the isolated Markdown check and this complete rerun pass.Review
GPT-6.1 Sol, Codex harness, xhigh effort, local inspection of committed head
648a4b32a31d74cb277f4a4f394f3cd027b221eb. Other-vendor review skipped under quest-review's trivial-change exemption: generated dependency-lock repair, one explicitly authorized advisory ignore, and quest bookkeeping; no production source, API or wire change. Verified parent chains, registry manifests/integrities, unchanged existing policy and TypeDoc patch, lock closure boundaries, and real before/after audits. No subagents started.Follow-ups
No new quest proposed. The recurring dependency audit owns removing the Rust ignore once core-models migrates and retiring each JS override when its parents declare safe ranges. No maintainer decision remains for this implementation.
(Written by GPT-6.1 Sol)