Skip to content

quest: close the open-GOP fixture quest - #7899

Merged
kixelated merged 7 commits into
mainfrom
quest/m0/interop-green/open-gop-fixture
Nov 4, 2026
Merged

kixelated merged 7 commits into
mainfrom
quest/m0/interop-green/open-gop-fixture

Conversation

@kixelated

@kixelated kixelated commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This PR closes the quest/m0/interop-green/open-gop-fixture.md quest, because its only open condition has cleared on scheduled evidence.

Scheduled Interop run 41863118968 ran on 2026-11-04 15:59Z at head 635dd54. That head includes moq-dev/moq#7814, whose merge commit abb5972 is an ancestor of it. The run's "Harness regressions" step passed, including:

(pass) software video recovery trims orphan pictures after join and later gap [1143.86ms]

Changes:

  • quest rm deletes quest/m0/interop-green/open-gop-fixture.md and its link in the Interop epic.
  • The epic now has no children left, so its README:
    • gets a size ([XS]).
    • drops "once these fixes land" from Waiting, since every fix has landed.
    • records what run 41863118968 found.
    • drops a stale note that moq-dev/moq#6990 is open. It has merged.
  • The IETF22 fallback quest records the Chromium stalls from scheduled Interop runs 41495461904, 41668668824, and 41863118968, and its Goal now covers moq-lite in any browser instead of only Firefox. This answers pullfrog's review thread.

Other failures in run 41863118968

The run failed only in "Media output and lifecycle". The case was chromium: media output + lifecycle → live incumbent fallback plays on old-moq-lite-07-wip, with audioStalled:true after the fallback.

quest/m0/test-flakes-2/ietf22-fallback.md already owns this. Its draft is moq-dev/moq#7656. Its Goal named only Firefox for moq-lite, after two Nightly runs, but this run and the two earlier scheduled Interop recurrences were all in Chromium, so this PR records them there. Every other step passed, including P2P and released wire compatibility.

Choices made without asking

  • I did not add the IETF22 fallback quest to the epic's Required. That section means "must finish before this starts", and the epic's own Waiting item already covers the pass.

Suggested follow-ups

None. The remaining red is owned as described above.

Public API: none. Wire: none.

Validation

  • quest check --base origin/main (pinned quest, built with nix build .#quest): 606 documents ok, after merging origin/main.
  • sh/markdown.sh check: passed.

Review

Codex, gpt-6.1-sol, medium effort, reviewed head 246628a against origin/main with quest review. Round 1 reported no findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 5 commits November 3, 2026 21:01
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
…/interop-green/open-gop-fixture

# Conflicts:
#	test/interop/clients/js/open-gop/main.ts
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Confirm scheduled open-GOP recovery passes quest: close the open-GOP fixture quest Nov 4, 2026
@kixelated
kixelated marked this pull request as ready for review November 4, 2026 18:02
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Interop quest README now labels the quest XS, updates its scheduled-run pass criterion, removes a reference to PR #6990, and reports the November 4 run results. The separate open-GOP fixture quest document was removed.

Merge Risk: Minimal · up to 67f38

The quest status update presents no identified merge-blocking risk and is ready to merge after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly states that the open-GOP fixture quest is being closed, which is the primary change.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description directly explains the deleted quest, README updates, scheduled Interop evidence, remaining failure ownership, and validation results. It is related to the changeset.
Finishing Touches
Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 18cc99c3-37a6-4abe-a389-a8b27460be8b
Commits

Reviewing files that changed from the base of the PR and between f37d964 and 67f3887.

Files selected for processing: 2
  • quest/m0/interop-green/README.md
  • quest/m0/interop-green/open-gop-fixture.md
Files with no reviewable changes: 1
  • quest/m0/interop-green/open-gop-fixture.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 67f388742eb9f82383f63ebeefca0cc08c74816d against base f37d964dd31987efe34b55375902de1380474235.

No actionable findings. Scheduled Interop run 41863118968 includes #7814 and its log confirms the required open-GOP recovery case passed. Deleting that completed child quest is supported; the parent correctly retains the whole-workflow pass requirement and ownership of the remaining fallback failure. #6990 is merged, so removing its stale open-PR note is also correct.

Verification: GitHub-only review of the documentation, workflow/source wiring and published run evidence. No local tests or quest commands were run.

(Written by review (OpenAI))

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Minor suggestions only.

Reviewed changes

  • Quest deletion: removes quest/m0/interop-green/open-gop-fixture.md now that a scheduled run passed the open-GOP recovery case.
  • Epic README: sizes the epic [XS], drops the stale "once these fixes land" and open-#6990 notes, removes the empty ## Required child link, and records run 41863118968's evidence.

I verified the cited run is the latest scheduled Interop run (head 635dd54), that #7814's merge commit abb5972 is an ancestor of it, that the Harness regressions step contains the quoted open-GOP pass line, and that the only failure was live incumbent fallback plays on Chromium with audioStalled:true. No tracked file still references the deleted quest.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Comment thread quest/m0/interop-green/README.md Resolved
Scheduled Interop runs 41495461904, 41668668824, and 41863118968 all hit
the fallback audio stall in Chromium on old-moq-lite-07-wip, so the quest's
Goal no longer limits the moq-lite case to Firefox.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Fallback evidence moved to its owner: quest/m0/test-flakes-2/ietf22-fallback.md now records the three scheduled Chromium Interop stalls (41495461904, 41668668824, 41863118968) on old-moq-lite-07-wip, so they survive the epic README's eventual deletion.
  • Goal widened: the IETF22 fallback quest's Goal now covers moq-lite in any browser instead of only Firefox.

I checked each cited run's job log directly. All three show FAIL chromium: media output + lifecycle in the live replacement and fallback: moq-lite-07-wip section with audioStalled:true; 41495461904 was later cancelled, but its fallback failure is logged before the cancel. The widened Goal matches that evidence, and the prior review thread about this evidence living only in the epic README is resolved.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 246628a

No new actionable findings. The added Chromium scope and evidence are supported: the media-job logs from scheduled runs 41495461904 and 41668668824 both log the old-moq-lite-07-wip live-incumbent fallback case with audioStalled:true, alongside the previously verified recurrence in 41863118968. The quest retains the need for a deterministic cause/reproduction and does not claim the stalls are fixed.

Overall direction: the update correctly records the observed browser coverage while retaining the parent workflow-pass requirement. The existing evidence still supports closing only the completed open-GOP child.

Verification limits: GitHub-only documentation and published job-log review. Matching symptoms do not establish a shared root cause. I did not rerun media tests or reproduce the stalls.

(Written by review (OpenAI))

@kixelated
kixelated added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 3dcd2c6 Nov 4, 2026
9 of 10 checks passed
@kixelated
kixelated deleted the quest/m0/interop-green/open-gop-fixture branch November 4, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant