Skip to content

quest: record the deployed release ordering fix; wait on a publishing release - #7901

Merged
kixelated merged 5 commits into
mainfrom
quest/m0/ci/release-pr-after-release
Nov 4, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m0/ci/release-pr-after-release

Conversation

@kixelated

@kixelated kixelated commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Rewrites the quest to what remains now that the release-ordering fix is deployed on both branches.

  • moq-dev/moq#7818 made just rs release publish before proposing on main (merged 2026-11-04).
  • moq-dev/moq#7842 already backported only that recipe to release (merged 2026-11-04T15:26Z), so this attempt opens no second backport PR.
  • That merge's Release RS run on release ran release-plz release (every crate "Already published") at 15:49:09Z, then release-plz release-pr at 15:49:10Z (every crate "already up to date"), and opened no release PR. Its merge touched no crate, so it shows the order but not a publishing release.

The quest stays, waiting on moq-dev/moq: the next approved release PR merge into release, whose Release RS log must show publishing finish before proposing and no stale PR.

Choices made without asking

  • The remaining wait names moq-dev/moq: rather than Maintainer:: it asks for no maintainer decision or extra action, only for the next release merge that would happen anyway, so it shouldn't rank first in quest waiting.
  • Kept the quest file rather than deleting it, since the Goal's "done when" needs a publishing release merge, which has not happened yet.

Impact

Public API: none. Wire: none. Quest bookkeeping only.

Validation

  • quest check --base origin/main: 605 documents ok.
  • quest gate nix develop --command just ci origin/main: pass (biome, markdown, gh, quest, shell, large files, text, toml, nix, justfile).
  • git diff --check: pass.

Review

Codex (quest review), gpt-6.1-sol at medium effort, round 1, reviewed 9134612ea8 against origin/main at 66d2f13129. No findings.

Follow-ups

None.

(Written by Claude Opus 5.5)

kixelated and others added 5 commits November 3, 2026 21:29
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
… release

The main fix (#7818) and its release backport (#7842) both landed, and the backport's own Release RS run published before proposing. What remains is evidence from a release merge that publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title A release merge opens no stale release PR quest: record the deployed release ordering fix; wait on a publishing release Nov 4, 2026
@kixelated
kixelated marked this pull request as ready for review November 4, 2026 18:08
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The quest document now summarizes the stale-PR incident, the publish-before-propose fix, and its recipe-only backport. It records that the backport run did not publish crates. The remaining check is to confirm, during the next approved release-PR merge into release, that publishing finishes before PR proposal and that no PR proposes the versions just published.

Merge Risk: Minimal · up to 91346

The documentation records the landed fix and backport without claiming publishing verification is complete. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the quest update: it records the deployed release-ordering fix and the wait for a publishing release.
Description check Passed The description directly explains the quest changes, the deployed fixes, the release evidence, and the remaining validation work.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 641c7988-060c-46bc-b7ea-b7705bf09609
Commits

Reviewing files that changed from the base of the PR and between f37d964 and 9134612.

Files selected for processing: 1
  • quest/m0/ci/release-pr-after-release.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Plan rewrite. Records #7818 landing publish-before-propose on main, #7842 backporting only the rs/justfile release recipe to release, and the backport merge's Release RS run exercising that order without a publishing release.
  • Waiting rewrite. Waits on the next approved release-plz release PR merging into release, with a concrete check of that run's log and an explicit delete-or-rewrite outcome.

I verified the claims against rs/justfile:470-473, .github/workflows/release-rs.yml:86-89, the merge metadata for #7818 and #7842, and the log for run 41857741087: release-plz release reports every crate already published before release-plz release-pr runs, and no PR is opened. The quest reads consistently with neighboring ## Waiting entries.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 9134612ea89f375285c78392deb21c83925ca0d3 against base f37d964dd31987efe34b55375902de1380474235.

No actionable findings. The main fix and recipe-only release backport are merged. The deployed run confirms release completed before release-pr, with all crates already published/up to date and no new release PR. Keeping the quest open for an actual publishing release correctly preserves the original acceptance criterion.

Verification: GitHub-only inspection of the quest, merged recipes/workflow and job logs. No tests, publishing or workflow dispatch were performed; the future publishing-release check remains outstanding.

(Written by review (OpenAI))

@kixelated
kixelated added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 732ced8 Nov 4, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m0/ci/release-pr-after-release branch November 4, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant