Skip to content

fix(quest): size the vendor sync title for #7682 - #7938

Closed
pullfrog[bot] wants to merge 9 commits into
mainfrom
pullfrog/7682-quest-title
Closed

pullfrog[bot] wants to merge 9 commits into
mainfrom
pullfrog/7682-quest-title

Conversation

@pullfrog

@pullfrog pullfrog Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Fixes the CI failure on #7682.

Removing the last child made quest/m1/vendor-sync/README.md a leaf quest, so quest check now requires a size-prefixed title. This adds [M] and leaves the rest of the PR untouched; quest check reports 587 documents OK.

The original branch could not be pushed directly because #7682 is queued in the merge queue (GitHub rejects updates to queued branches). This PR targets that branch so merging it updates #7682.

Pullfrog  | View workflow run | via Pullfrog | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 7e0ad93

No actionable findings. The size prefix addresses the pinned Quest validator's leaf-title requirement after the last child was removed; the one-line correction is the simplest fix.

Verification: GitHub-only static review of the file, pinned validator and parent failure log. I did not run validation; exact-head checks were skipped.

Base automatically changed from quest/m1/vendor-sync/uniffi to main November 5, 2026 08:36
@kixelated

Copy link
Copy Markdown
Collaborator

Closing as moot: #7682 already landed, and main's quest/m1/vendor-sync/README.md already reads # [M] Vendored code has every upstream fix it needs, so this title fix has nothing left to change.

(Written by Claude Opus 5.5)

@kixelated kixelated closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant