Repository navigation
quest: the queue concurrency trial ran out of disk - #7970
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit d1debde. No actionable findings. Recording the aborted experiment without claiming a performance winner and requiring warm-cache capacity before another trial is a sound direction. Minor chronology: the linked run started at 17:12Z; its first logged no-space error was at 17:16:35Z, so quest/m0/ci/queue-concurrency.md:42–43 could distinguish those times.
Verification: GitHub-only static review of the plan, linked job logs and configuration. I did not run tests or independently verify the host storage snapshot.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ No critical issues — two accuracy points inline, neither blocks.
Reviewed changes
This run reviewed the single quest-only commit that records how the merge-queue concurrency trial ended.
- Trial ended early — the plan text now says the maintainer stopped the
max_entries_to_build: 2window after ~2.2 hours, records the ruleset returning to 1 at 18:02:15Z, and cancels the scheduled 2026-11-07 revert. - Failure recorded —
nixos-moq-ci2ran out of space during a merge-group build for #7716, attributed to the shared 667 GiB XFS project quota plus each queue runner's own Cargo targets and mbx caches. - Retry prerequisite — sizing the per-runner caches or the quota in
kixelated/nixosis now a stated condition before another two-build attempt, with the trial window declared too short and disturbed to compare.
The core facts check out: run 42072368255 is #7716's merge group on nixos-moq-ci2, and #7716 re-merged at 18:02:23Z. The quest stays open, and no other quest file depends on the trial's state.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
|
|
||
| It ran out of disk the same day, so the maintainer ended it early | ||
| (decided 2026-11-05, maintainer, /quest-complete; ruleset back to 1 at | ||
| 2026-11-05T18:02:15Z, scheduled revert cancelled). At 17:12Z |
There was a problem hiding this comment.
The merge-group build did not fail at 17:12Z: the job started 17:12:49Z, hit error: couldn't create a temp dir: No space left on device at 17:16:35Z, and concluded 17:16:42Z. Since this record uses second-level timestamps everywhere else, 17:12Z reads as the failure time and will mislead anyone reconstructing the incident.
| hard; 578 GiB used afterwards), and each moq queue runner keeps its own | ||
| Cargo targets and mbx caches inside it (`modules/ci-runners.nix`: MBX target |
There was a problem hiding this comment.
This says each queue runner keeps its own mbx caches, while the Method paragraph above (line 31-33) still warns that "the shared mbx cache" could erase the gain and tells the retry to watch for it. In this failing job mbx state lived in /var/cache/github-runner-home/.cache/mbx on moq-ci2, and .github/actions/rust-cache/action.yml notes runners on one host may share a home but never a workspace, so the per-runner wording here looks right and the shared-cache premise is stale. Mark that earlier sentence superseded (or say which holds) so the record and the retry guidance agree.
Records the end of the merge-queue concurrency trial in
quest/m0/ci/queue-concurrency.md.nixos-moq-ci2, failed a merge-group build withNo space left on device. That dropped fix(watch,publish): keep audio across declared ends; repair browser media tests #7716.nixosshares one 667 GiB XFS project quota, and each moq queue runner keeps its own Cargo targets and mbx caches inside it.max_entries_to_build: 1at 18:02Z, and the scheduled revert was cancelled.Public API: none. Wire: none.
Review
d1debdec5fskipped as trivial: a quest-only edit that records the trial's outcome, written by Claude Opus 5.5.quest checkpasses.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code