[kixelated]

The Route doctest from moq-dev/moq#7806 passed Default::default() to create_track. That can't infer impl Into<Option<track::Info>>, so cargo test -p moq-net --doc fails on main with E0283. CI's Check doesn't run doctests, so the failure only showed up in the land fixer's local validation of moq-dev/moq#7988.

This passes None instead, as ietf/session.rs already does.

cargo test -p moq-net --doc passes.

Review

Head f37b8af: local review skipped as justified — a one-line doctest change (Default::default() → None) matching the existing ietf/session.rs call; pullfrog approved this head. Verified cargo test -p moq-net --doc passes on this head merged with main 0672ad5 (10 passed, 2 ignored; 3 passed).

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3c7f092a-d4c7-4f69-9236-6c050aac4f4c

Commits

Reviewing files that changed from the base of the PR and between d6fcf6d and f37b8af.

Files selected for processing: 1

• rs/moq-net/src/model/origin.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[kixelated]

Automated review by review (OpenAI)

Reviewed head: f37b8af.

No actionable findings. The one-line Route doctest change gives create_track an inferable Option<track::Info>; its implementation uses unwrap_or_default(), so None retains the intended default track metadata. This is an appropriately scoped fix; no code changes suggested.

Verification: inspected the complete diff, surrounding doctest, API implementation, and current discussion/reviews through GitHub. No earlier code-review findings were present. Static review only: I did not run cargo test -p moq-net --doc or other checks, and the PR's reported doctest pass was not independently reproduced.

[pullfrog]

✅ No new issues found.

Reviewed changes

• Route doctest: create_track("catalog.json", None) replaces Default::default(), which cannot infer impl Into<Option<track::Info>> (E0283) because both Option<track::Info> and track::Info satisfy the bound. None is also the form documented on Broadcast::create_track and used in ietf/session.rs.
• Verified locally: cargo test -p moq-net --doc passes, including the Route doctest at line 2932.

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏}