Skip to content

chore(quest): finish the joined-head FETCH race backport - #7998

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/backport-fill-head-race
Nov 6, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/backport-fill-head-race

Conversation

@kixelated

@kixelated kixelated commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Removes quest/m0/backport-fill-head-race.md and its link: the backport is published.

  • moq-dev/moq#7680 merged into release; release PR moq-dev/moq#7936 published moq-net 0.3.21.
  • Verified against the downloaded crate (not the repo): moq-net-0.3.21/src/ietf/subscriber.rs contains wait_group_head (called from the cache-miss path) and the a_miss_waits_for_the_subscriptions_own_fill test.

Choices made without asking: the stale local branch from an earlier attempt (already-landed #7903 work) was not resumed; this PR is built from the fresh claim commit.

🤖 Generated with Claude Code

Review

Skipped: the change only deletes a finished quest file and its milestone link.

(Written by Opus 5.5)

kixelated and others added 2 commits November 5, 2026 22:27
…e joined-head wait

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Ship the joined-head FETCH race backport chore(quest): finish the joined-head FETCH race backport Nov 6, 2026
@kixelated
kixelated marked this pull request as ready for review November 6, 2026 06:28

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted the finished backport quest — quest/m0/backport-fill-head-race.md is removed in its entirety, per the repo convention that a completed quest leaves the tree by outright deletion with no prose record.
  • Dropped its milestone link — the matching ## Required bullet in quest/m0/README.md is gone, leaving no dangling tree edge.

I verified the removal is complete and the stated outcome is real rather than trusting the body:

  • #7680 merged into release (merge commit dc3478a), and #7936 published the release cut from release (a8e297c).
  • The downloaded moq-net-0.3.21.crate (.cargo_vcs_info.json sha a50cda6, two commits past dc3478a on release) contains wait_group_head in src/ietf/subscriber.rs, called from the cache-miss End::Fetch path, plus the a_miss_waits_for_the_subscriptions_own_fill test.
  • Grepping the head tree for fill-head-race and joined-head FETCH race fix finds no remaining references; the quest/m3/ietf-absolute-join-race.md mention is of the still-valid PR #7680, not of the deleted file.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The README no longer lists the joined-head FETCH race fix as a release backport priority. The quest document describing the proposed fix, related pull requests, and release steps is deleted. No code changes are described.

Merge Risk: Minimal · up to 66f49

This documentation-only cleanup has no identified merge-blocking risk. It does not change runtime behavior.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title identifies the completed backport quest that the PR removes.
Description check Passed The description identifies the deleted quest document and milestone link.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9daf1c22-fe6e-4006-a805-8355633fa619
Commits

Reviewing files that changed from the base of the PR and between 0672ad5 and 66f4971.

Files selected for processing: 2

  • quest/m0/README.md
  • quest/m0/backport-fill-head-race.md
Files with no reviewable changes: 1

  • quest/m0/backport-fill-head-race.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@kixelated
kixelated added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 16c802f Nov 6, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m0/backport-fill-head-race branch November 6, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant