Repository navigation
quest: re-create the vendor sync in m3 with WebRTC and SCReAMv2 children - #8019
Conversation
Quest-Claim: 425c2ff17eeb1160
Every child of the 2026-10-30 vendor sync merged. Scan the tree for code vendored since, add WebRTC (GoogCC, NetEq) and SCReAMv2 children, and re-create the questline under m3 behind the release cut, carrying each child's checked heads and what the run learned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe vendor-sync quest moved from the m2 cut gate into the m3 quest structure. Its README updates the scan criteria, records WebRTC and SCReAMv2 in scope, and lists required child quests. The PR adds recurring sync plans for Quinn, rml, SCReAMv2, UniFFI, v4l, VAAPI, nvenc, and WebRTC. Related quest links now point to the m3 vendor-sync README. Merge Risk:
|
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: a28b2ed
No actionable findings in the 14-file change. The recurrence wiring is consistent: the completed sync leaves the current m2 gate, all eight recreated children require the release cut, and the cut explicitly moves the next sync back under the recreated gate. The carried-forward baselines and new WebRTC/SCReAMv2 scopes match the repository records inspected.
Overall direction: the documentation-only re-creation is coherent; no change requested from this review.
Verification limits: GitHub-only static review of the diff and supporting repository documents/source. I did not run quest context, quest check, or tests, nor repeat the external upstream/advisory audits. The head's Check workflow was still in progress when checked.
There was a problem hiding this comment.
ℹ️ Minor suggestion only — the quest move and its eight children otherwise check out.
Reviewed changes
Reviewed the quest-only move of the vendor sync from quest/m2/cut-gate/vendor-sync/ to quest/m3/vendor-sync/ (git sees a rename), the eight child quests, and the link rewrites that follow it.
- Epic re-created in m3 — the renamed README gains a
Requiredlist of eight children, widens the scan to carriedLICENSE/PATENTS/Copyrightnotices, and records the 2026-11-05 scan's two new upstreams. - Two new children —
webrtc.mdfor moq-congestion's GoogCC and moq-audio's NetEq time stretch, andscream.mdfor SCReAMv2, each with baselines, recorded deviations, and bake-off drop conditions. - Six carried children — quinn, rml, v4l, nvenc, vaapi, and uniffi, with each run's checked heads and lessons moved from the epic README or the vendored crate's record into the child.
- Link rewrites — the m2 cut gate drops the vendor sync from
Required, and the m3 milestone, dependency audit, exporter switch, and release cut point at the new path.
I verified the cited merge dates (#7546, #7547, #7856), external heads and commit dates, the UniFFI pin table against rs/uniffi-bindgen/Cargo.toml and flake.nix, every path the children name, and that all /quest/... links in the changed files resolve. The scan's coverage holds: no in-tree vendored upstream is left without a child, and OpenH264 is a crates.io openh264-sys2 dependency rather than in-tree code.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This re-review covers the one commit pushed since the last review of a28b2ed.
- Discord refs named as branches —
quest/m3/vendor-sync/vaapi.mdnow callsdiscord-0.0.13anddiscord-0.0.5branches instead of tags, which is what both forks actually publish.
I confirmed both refs live: refs/heads/discord-0.0.13 on discord/cros-libva resolves to 896a248e, and refs/heads/discord-0.0.5 on discord/cros-codecs resolves to 9cdecb19, each exactly the SHA the document cites. Nothing else in the PR changed.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Completes and deletes quest/m2/cut-gate/vendor-sync/README.md: every child of the 2026-10-30 vendor sync had merged, so this is the epic's own work. The questline is re-created at
quest/m3/vendor-sync/behind the release cut, which moves it under the re-created m2 cut gate.Changes
LICENSE,PATENTS, andCopyrightnotices,gitdependencies, and forked flake inputs. Two new upstreams turned up, and each gets a child:webrtc.md, [S]): moq-congestion'sgccGoogCC port, recorded at WebRTC556f7eec27(moq-dev/moq#7546), and moq-audio's NetEq time stretch (moq-dev/moq#7856). Both ports come from one upstream, so they share one child.scream.md, [XS]): moq-congestion'sscream, ported from draft -01 and checked against Ericsson's reference (moq-dev/moq#7547).Requiredno longer lists the vendor sync. m3'sRequirednow links the new questline. Prose links in the cut gate, the release cut, the dependency audit, and the exporter switch point at the new path.Choices made without asking
mainas of 2026-11-04, the date the port read it. SCReAMv2 starts from Ericssonmaster4b973bab, the head when its port merged, after confirming the port's constants match. WebRTC's gitiles history pages need a sign-in, so the WebRTC child says to clone instead.LICENSE,PATENTS, orCopyrightnotices. The GoogCC port surfaced that way.@moq/libav(builds pinned upstream releases unmodified).Public API and wire
None. Quest files only.
Validation
quest check --base origin/main: 587 documents ok.quest unblocked quest/m3/vendor-sync/quinn.md: blocked byquest/m3/release/cut.md, as intended.Review
Codex
gpt-6.1-sol(medium effort) reviewed heada28b2ed1againstorigin/main0672ad56in round 1. It reported no findings.Head
5e831633was not re-reviewed: its only change sincea28b2ed1swaps "tag" for "branch" in two words ofquest/m3/vendor-sync/vaapi.md, naming Discord'sdiscord-0.0.13anddiscord-0.0.5fork refs as branches. That is too trivial to review (skip recorded by the authoring model, Claude Opus 5.5).Suggested follow-ups
None.
(Written by Claude Opus 5.5)