Skip to content

Nightly's Miri job stays inside its time budget - #8065

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/nightly/miri
Nov 7, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/nightly/miri

Conversation

@kixelated

@kixelated kixelated commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Claims quest/m0/nightly/miri.md.

Today's scheduled Nightly (run 42236107954, fbef872) failed Tests (rs miri) at build time: model/track.rs test helpers called the async-only group::Consumer::read_frame, and the Miri selection builds moq-net without async. moq-dev/moq#7995 already gated those helpers; cargo test --locked -p kio -p moq-net --lib --no-run fails at fbef872 and builds on 1ae5c5f.

Scheduled Nightly run 42377867523 (2026-11-07, b580585, includes moq-dev/moq#7997) passed Tests (rs miri): 228 tests in the first pass (425.6s), 55 in the second (166.0s), no SLOW test in either. This PR deletes quest/m0/nightly/miri.md and its Required entry in the parent README.

Choices made without asking:

  • Verified with a native build of the same package selection, since Miri isn't installed on this host (no rustup); it reproduces the exact E0599.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1b831-5f22-7310-a372-e919c00718c3, round 1
  • Head: 9b8a347
  • Base: origin/main at 76bb38f
  • Score: 10/10, The cleanup consistently deletes the completed Miri quest and its parent checklist entry, with no remaining references, behavioral changes, or identifiable defects.
  • Findings: none

kixelated and others added 2 commits November 6, 2026 12:06
Quest-Claim: 1d9b08c9cf9e248e
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 7, 2026 22:47
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5d1d5886-40db-423a-a58a-25ed02b12eea
Commits

Reviewing files that changed from the base of the PR and between 76bb38f and 9b8a347.

Files selected for processing: 2

  • quest/m0/nightly/README.md
  • quest/m0/nightly/miri.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 9b8a347 against base 76bb38f. No actionable findings in this two-file completion cleanup.

Verified the cited scheduled Nightly's ARM Miri job succeeded in about 14m23s. Its logs record both passes: 228 tests in 425.577s and 55 in 165.973s, with no SLOW test entries. That supports the deleted quest's remaining timing-validation requirement; its parent Required link is removed consistently.

Direction: retain the existing timeout and per-test limits. This verifies the Miri lane, not the other failing Nightly jobs.

Verification limits: GitHub-only inspection of the complete diff and published job metadata/logs. No local Miri, builds, tests or quest validation run. Rechecked open/non-draft state, full head/base and reviews immediately before posting.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted the Miri quest — quest/m0/nightly/miri.md is removed after the scheduled Nightly's Tests (rs miri) job passed in run 42377867523 (13:50 → 14:04, well inside the 60-minute budget).
  • Removed the parent checklist entry — quest/m0/nightly/README.md no longer lists the quest under ## Required.

The deletion matches the quest's own remaining step and the established cleanup pattern. A repo-wide search for miri.md / nightly/miri finds no dangling references, and the epic's other child (macos.md) remains listed. The rest of that Nightly run's failures (gate, uring, relay benchmarks, audio quality, moxygen) belong to other quests and are unaffected by this change.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 16f15e2 Nov 7, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/nightly/miri branch November 7, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant