Repository navigation
Nightly's Miri job stays inside its time budget - #8065
Conversation
Quest-Claim: 1d9b08c9cf9e248e
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 9b8a347 against base 76bb38f. No actionable findings in this two-file completion cleanup.
Verified the cited scheduled Nightly's ARM Miri job succeeded in about 14m23s. Its logs record both passes: 228 tests in 425.577s and 55 in 165.973s, with no SLOW test entries. That supports the deleted quest's remaining timing-validation requirement; its parent Required link is removed consistently.
Direction: retain the existing timeout and per-test limits. This verifies the Miri lane, not the other failing Nightly jobs.
Verification limits: GitHub-only inspection of the complete diff and published job metadata/logs. No local Miri, builds, tests or quest validation run. Rechecked open/non-draft state, full head/base and reviews immediately before posting.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Deleted the Miri quest —
quest/m0/nightly/miri.mdis removed after the scheduled Nightly'sTests (rs miri)job passed in run 42377867523 (13:50 → 14:04, well inside the 60-minute budget). - Removed the parent checklist entry —
quest/m0/nightly/README.mdno longer lists the quest under## Required.
The deletion matches the quest's own remaining step and the established cleanup pattern. A repo-wide search for miri.md / nightly/miri finds no dangling references, and the epic's other child (macos.md) remains listed. The rest of that Nightly run's failures (gate, uring, relay benchmarks, audio quality, moxygen) belong to other quests and are unaffected by this change.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

Claims quest/m0/nightly/miri.md.
Today's scheduled Nightly (run 42236107954, fbef872) failed
Tests (rs miri)at build time:model/track.rstest helpers called theasync-onlygroup::Consumer::read_frame, and the Miri selection buildsmoq-netwithoutasync. moq-dev/moq#7995 already gated those helpers;cargo test --locked -p kio -p moq-net --lib --no-runfails at fbef872 and builds on 1ae5c5f.Scheduled Nightly run 42377867523 (2026-11-07, b580585, includes moq-dev/moq#7997) passed
Tests (rs miri): 228 tests in the first pass (425.6s), 55 in the second (166.0s), no SLOW test in either. This PR deletesquest/m0/nightly/miri.mdand its Required entry in the parent README.Choices made without asking:
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.01a1b831-5f22-7310-a372-e919c00718c3, round 1The cleanup consistently deletes the completed Miri quest and its parent checklist entry, with no remaining references, behavioral changes, or identifiable defects.