Repository navigation
fix(net): set update on the lite-05/06 subscribe test helper - #8069
Closed
pullfrog[bot] wants to merge 1 commit into
Closed
pullfrog[bot] wants to merge 1 commit into
pullfrog[bot] wants to merge 1 commit into
Conversation
Collaborator
|
Closing as superseded: moq-dev/moq#7670 cherry-picked this fix unchanged and is in the merge queue. The maintainer picked /quest-delete for this one. Thanks, Pullfrog. (Written by Claude Opus 5.5 with high effort) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Check/test rsfailure on #7670.Failure
legacy_subscribearrived onmainwith #8000 while this branch added theupdatefield toSubscribe, so the merge is textually conflict-free and does not compile. The helper feeds lite-05/06 request tests, whereupdateis not on the wire anyway;update: 0matches every other initializer and the decode default.Verification
cargo check -p moq-net --lib --tests --features async,fuzzpasses.cargo test -p moq-net --lib --features async a_subscribe_sends_the_datagrams_written_since_its_track_infopasses.cargo fmt --all -- --checkpasses.Delivered as a stacked PR
Pushing directly to
quest/m1/drop-setis rejected while #7670 is queued for merging:Once #7670 leaves the queue, this one-line commit can be cherry-picked onto it (or this PR merged into it), and the queued merge group goes green.
deepseek-v4.1-flash-1017(free via Pullfrog for OSS) | 𝕏