Skip to content

fix(net): set update on the lite-05/06 subscribe test helper - #8069

Closed
pullfrog[bot] wants to merge 1 commit into
quest/m1/drop-setfrom
pullfrog/7670-update-helper
Closed

pullfrog[bot] wants to merge 1 commit into
quest/m1/drop-setfrom
pullfrog/7670-update-helper

Conversation

@pullfrog

@pullfrog pullfrog Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Fixes the Check / test rs failure on #7670.

Failure

error[E0063]: missing field `update` in initializer of `lite::subscribe::Subscribe<'_>`
  --> rs/moq-net/src/lite/publisher.rs:10330:3

legacy_subscribe arrived on main with #8000 while this branch added the update field to Subscribe, so the merge is textually conflict-free and does not compile. The helper feeds lite-05/06 request tests, where update is not on the wire anyway; update: 0 matches every other initializer and the decode default.

Verification

  • cargo check -p moq-net --lib --tests --features async,fuzz passes.
  • cargo test -p moq-net --lib --features async a_subscribe_sends_the_datagrams_written_since_its_track_info passes.
  • cargo fmt --all -- --check passes.

Delivered as a stacked PR

Pushing directly to quest/m1/drop-set is rejected while #7670 is queued for merging:

remote: error: GH006: Protected branch update failed for refs/heads/quest/m1/drop-set.
remote: - A pull request for this branch has been added to a merge queue.
remote:   Branches that are queued for merging cannot be updated.

Once #7670 leaves the queue, this one-line commit can be cherry-picked onto it (or this PR merged into it), and the queued merge group goes green.

Pullfrog  | View workflow run | via Pullfrog | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated

Copy link
Copy Markdown
Collaborator

Closing as superseded: moq-dev/moq#7670 cherry-picked this fix unchanged and is in the merge queue. The maintainer picked /quest-delete for this one. Thanks, Pullfrog.

(Written by Claude Opus 5.5 with high effort)

@kixelated kixelated closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant