Skip to content

quest: release-audio-group-cap waits on the release fix (#8118) - #8107

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/release-audio-group-cap
Nov 7, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/release-audio-group-cap

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Claims quest/m0/release-audio-group-cap.md and rewrites it to what remains.

Summary

  • The code fix is moq-dev/moq#8118, into release only: the audio encoder rolls a group before MAX_GROUP_FRAMES / MAX_GROUP_CACHE_BYTES. main has no group cap, so it gets no code change.
  • This PR, on main, rewrites the quest to [XS], points its Plan at moq-dev/moq#8118, and adds a Maintainer: ## Waiting item: merge it and cut the next @moq/publish patch. A later PR deletes the quest once the patch publishes, as moq-dev/moq#7279 did for groupDuration.

Choices made without asking

  • Two PRs. The quest tree lives on main and the fix must target release, so one PR cannot do both. The claim PR carries the quest bookkeeping; the fix is a separate backport/ branch, since only claims use the quest/ namespace. Merging this one first is fine: the quest then stays accurate, waiting on the release merge and publish.

Public API: none. Wire: none.

Validation

  • quest check --base origin/main: 602 documents ok.

Review

Skipped for head 6f9cbb9341: the diff only rewrites one quest file, which quest check validates. The code's review is on moq-dev/moq#8118 (Codex gpt-6.1-sol, medium, head 2da8483b00, no findings).

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Release's audio encoder rolls groups before the cap quest: release-audio-group-cap waits on the release fix (#8118) Nov 7, 2026
@kixelated
kixelated marked this pull request as ready for review November 7, 2026 02:16
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1c5939f-2ae7-4b54-b5c7-c8a5d8dd2dbf
Commits

Reviewing files that changed from the base of the PR and between ce0a4f0 and 6f9cbb9.

Files selected for processing: 1

  • quest/m0/release-audio-group-cap.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 6f9cbb9
Base: ce0a4f0

No actionable findings in this bookkeeping change. The quest correctly remains open for the release merge and publication, points to #8118's actual release-only implementation, and requires checking that the published cut contains that merge rather than relying on a version number alone. No code or release action is performed here.

Verification: GitHub-only static inspection of the complete quest and the linked #8118 changes. I did not execute quest validation or query npm. Check was still in progress when checked.

(Written by review (OpenAI))

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Quest rescoped to [XS] — quest/m0/release-audio-group-cap.md now states the remaining work is the release-only fix in #8118 plus its patch publish, with main explicitly getting no change.
  • Waiting item added — a Maintainer: wait to merge #8118 into release, cut the next @moq/publish patch, and verify the published cut contains the merge commit.

I verified the plan's load-bearing claims instead of taking them from the body:

  • #8118 is open against release, mergeable, and its tests do exercise 2.5 ms frames at MAX_GROUP_FRAMES and 1 MiB frames at MAX_GROUP_CACHE_BYTES under a 60 s groupDuration.
  • origin/release still defines MAX_GROUP_FRAMES = 8192 and MAX_GROUP_CACHE_BYTES (32 MiB) in js/net/src/group.ts, while main defines neither, so "main has no group cap" holds.
  • origin/release js/publish/package.json and npm latest are both 0.5.5, so the wait is not yet satisfied.
  • quest check --base origin/main --branch pr-8107 passes with "quest: 602 documents ok", matching the body.
  • Release PRs land as real merge commits (#7290 is d0cff5ac8b, two parents), so "the release cut contains #8118's merge commit" is a check a later run can actually evaluate.

The prior plan hint to roll early like js/json's window encoder is superseded by #8118's exact-net-cap roll, which that PR's body documents; the rewritten Plan's "rolls at the net caps" matches the code.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 1ee8eec Nov 7, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/release-audio-group-cap branch November 7, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant