Repository navigation
quest: delete webgpu-safari - #8134
Conversation
The maintainer abandoned the remaining physical-iPhone check. macOS Safari 26.6.2 was verified on 2026-11-03 (80/80 direct, 112/112 moq-watch), and the HEVC probe-and-refuse fix landed in #7765. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head e5b67440a88ad3942c76669f7d6f0138e1caad68 against base be5dd24e3a589151cc774ebabfef7a719c298985.
No actionable findings. The change removes the abandoned Safari verification quest and its milestone link without changing renderer behavior or claiming the remaining iOS checks passed. The recorded macOS evidence remains in history, and #7765's encoder-probe fix is merged.
Direction: this is consistent with the recorded decision to drop the remaining physical-device work. Keep the distinction between abandoning that verification and completing it.
Verification: GitHub-only static review of both changed files, including the deleted quest at the base, repository and quest guidance, and the linked fix's state. No Safari/device tests or commands were run; I did not independently reproduce the historical macOS results or verify the omitted iOS cases. Rechecked open/non-draft state, full head/base, reviews, and discussion immediately before posting.
(Written by review (OpenAI))
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This PR abandons a quest and deletes it, with no code, public API, or wire impact.
- Deletes
quest/m1/webgpu-safari.md— removes the open Safari 26 WebGPU verification quest, whose only remaining item was a physical iPhone/iPad run the maintainer chose not to do. - Drops its
quest/m1/README.mdentry — the milestone'sRequiredlist no longer points at the deleted file.
No stale references remain: git grep webgpu-safari is empty at the head, and the base had exactly the one README link this PR removes. sh/markdown.sh check passes, and no remote quest/m1/webgpu-safari branch exists to clean up. The quest's evidence and the HEVC probe-and-refuse decision stay in git history and #7765, and the renderer's unimportable-frame behavior is unchanged by design.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Abandons
quest/m1/webgpu-safari.mdand removes its link fromquest/m1/README.md.All that remained was the maintainer's physical iPhone/iPad run: iOS camera capture, device orientation, and a valid frame that actually fails to import. The maintainer chose not to do it. What the quest did verify stays in git history:
<moq-watch>cases, run 2026-11-03.The renderer's existing error behavior stays as it is: an unimportable frame throws and is skipped.
Review
Skipped: this PR only deletes a quest.
Public API: none. Wire: none.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code