Skip to content

quest: add studio's evidence to interop-shutdown-warnings - #8152

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/subscriber-abort
Nov 7, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/subscriber-abort

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

moq-dev/studio#95 logged track::Producer dropped without finish() or abort() at teardown in 2 of about 12 runs of a test where a relay takes in a publisher's broadcast. The backtrace points into moq-net: the subscriber side drops the tracks it took in without aborting them when a session ends.

quest/m3/interop-shutdown-warnings.md already covers this warning ("which producer the CLI or the relay drops"), so this adds the evidence there instead of planning a second quest. Picked under /afk with the recommended option.

Review

Skipped a local quest review re-run: the change is 6 lines of plan prose in one quest file, no code. The OpenAI review on this head (review) found nothing actionable, and pullfrog approved.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a2b0b524-20a3-4ce0-b2f0-ee5b8346afa2
Commits

Reviewing files that changed from the base of the PR and between 564f53a and ace12a8.

Files selected for processing: 1

  • quest/m3/interop-shutdown-warnings.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Checked the new evidence recorded in quest/m3/interop-shutdown-warnings.md: the six appended lines under the "Unfinished producer" plan bullet capture moq-dev/studio#95's teardown warning (2 of ~12 runs of the_program_reaches_a_relay, catalog.json once and 1.avc3 once), its moq-net backtrace, and the suggested subscriber-side abort.
  • Verified the added claims against the studio PR and the current source: SourceServe owns TrackServeRun/TrackEntry, whose Accepted.producer drops without abort on session teardown, so the subscriber-side cause is plausible and material.
  • Confirmed the edit fits the quest: the same warning is already owned by this quest's second plan bullet, and folding the evidence in instead of opening a second quest matches the quest rules. Formatting and indentation match the surrounding list.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head ace12a8 against base 564f53a.

No actionable findings. The added occurrence count, track names and subscriber-side teardown attribution match studio#95's published follow-up. The quest correctly treats this as a possible shared cause, retains the requirement to reproduce the interop warnings, and adds the evidence to the existing investigation rather than duplicating it.

Direction: confirm ownership and session-end cleanup before deciding which tracks to abort. Verification limits: GitHub-only review of the complete one-file diff, surrounding quest and linked PR report; no backtrace capture, source-path reproduction or interop tests run. Rechecked open/non-draft state, full head/base and published reviews immediately before posting. COMMENT only, not approval.

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 10fc09e Nov 7, 2026
11 of 12 checks passed
@kixelated
kixelated deleted the quest-plan/subscriber-abort branch November 7, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant