Skip to content

docs(quest): Smoke substitutes main's relay and CLI from nix.moq.dev - #8161

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/ci/nix-cache-verify
Nov 7, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/ci/nix-cache-verify

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes Verify the Nix runtime cache: its Waiting condition cleared.

Evidence

After moq-dev/moq#8114 merged (2026-11-07 09:08Z), the scheduled Smoke run 42382978607 (ubuntu-latest / nix, job 128434330416) logged in "Build moq from the flake":

Building github:moq-dev/moq/b98833c40aacdd7b3cdea8cc1fb882a77fcc6bf6 (newest main commit with a successful Cache run)
copying path '/nix/store/f3k4h7z1f2cbmnmbbhq05hr114hmhg77-moq-relay-0.17.2' from 'https://nix.moq.dev'...
copying path '/nix/store/bgwgf7wf7w5n3a4vvpg6g69j7fxh0m74-moq-cli-0.14.2' from 'https://nix.moq.dev'...

The job log has no building '...' line. Both binaries were substituted, not compiled.

Choices made without asking

  • Removed the deleted quest's links from quest/m0/ci/README.md, and from the Related sections of cachix-retire.md, mbx-r2-verify.md, and nix-cache-expiry.md. Each of those sections then had no entries, so the heading went too (quest check passes).
  • Left the stale local branch quest/m0/ci/nix-cache-verify alone. It holds the earlier ci: cache Smoke's Nix runtime packages on main #7662-era attempt, which was squash-merged already.

Review

Skipped at de5ed66: the change only deletes a finished quest and its links (13 lines removed, no code changed). quest check passes.

Suggested follow-ups

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits November 7, 2026 08:14
Scheduled Smoke run 42382978607 built pinned main b98833c and copied
moq-relay-0.17.2 and moq-cli-0.14.2 from https://nix.moq.dev with no
building lines, so the runtime-cache quest is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Verify the Nix runtime cache docs(quest): Smoke substitutes main's relay and CLI from nix.moq.dev Nov 7, 2026
@kixelated
kixelated marked this pull request as ready for review November 7, 2026 16:15
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: adafa5c7-1ce9-409d-bf32-0944d6a4d349
Commits

Reviewing files that changed from the base of the PR and between 619f5c8 and de5ed66.

Files selected for processing: 5

  • quest/m0/ci/README.md
  • quest/m0/ci/cachix-retire.md
  • quest/m0/ci/mbx-r2-verify.md
  • quest/m0/ci/nix-cache-expiry.md
  • quest/m0/ci/nix-cache-verify.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit de5ed66 against base 619f5c8.

No actionable findings. The deleted quest's waiting condition is supported by the linked scheduled Smoke run 42382978607: I checked its GitHub metadata and job 128434330416's log, which pins b98833c and copies both moq-relay-0.17.2 and moq-cli-0.14.2 from https://nix.moq.dev. There is no building ' line in that fetched job log. The documentation-only deletion and removal of its related links are consistent with closing this main-cache verification task.

Direction: retain the separate cache-expiry and release/Cachix follow-ups; this successful substitution does not establish long-term retention or release-tag coverage.

Verification limits: GitHub-only diff and hosted-run/log inspection. I did not run quest validation, build binaries, dispatch CI, or test cache behavior independently. This is a COMMENT, not an approval.

(Written by review (OpenAI))

@pullfrog pullfrog Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Deleted quest/m0/ci/nix-cache-verify.md — the finished "Verify the Nix runtime cache" quest, now that its Waiting condition is met.
  • Dropped its entry from quest/m0/ci/README.md — the ## Required list no longer points at the deleted file.
  • Removed three ## Related sections — in cachix-retire.md, mbx-r2-verify.md, and nix-cache-expiry.md, each of which held only the deleted quest, so the heading went too.

I verified the evidence rather than taking it on trust: run 42382978607 is a successful scheduled run on main whose nix job pins the same b98833c rev and logs copying path '...moq-relay-0.17.2' from 'https://nix.moq.dev' and copying path '...moq-cli-0.14.2' from ..., with no building '/nix/store/... line for either binary. No reference to the deleted quest path or title remains anywhere in the tree, and the Quest check passes on de5ed663. Removing the now-empty ## Related sections matches how earlier removals were handled, and expiry coverage still lives in quest/m0/ci/nix-cache-expiry.md.

This is exactly the outcome the quest was waiting on.

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 18b939a Nov 7, 2026
14 checks passed
@kixelated
kixelated deleted the quest/m0/ci/nix-cache-verify branch November 7, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant