Repository navigation
quest: session policy lives in moq-net, finished - #8172
Conversation
Quest-Claim: 57336650aa5712cc
moq-webrtc's data channel transport runs its sessions through Client::connect_with and Listener::accept_with (#8122), the last clause of the epic's Goal, so the epic is deleted along with every link to it and the held-epic prose that named it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head 6c3d11b.
The completion cleanup is consistent with the current handoffs: WebRTC uses Client::connect_with / Listener::accept_with, and accept deadlines and admission/window policy are owned by moq-net. The documented connect_with timeout wrapper uses the shared policy value; removing the finished epic and its milestone links is a reasonable direction. No actionable findings in this four-file documentation change. Verification: GitHub-only static review of the diff and relevant WebRTC, tokio, server and reconnect code; I did not run tests or independently reproduce the entire goal audit.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Epic deleted —
quest/m1/session-policy/README.mdis removed, and its bullet is dropped from theRequiredlists inquest/m1/README.mdandquest/m2/README.md. - Held-epic prose updated —
session-policyis removed from the held list inquest/m1/README.mdand fromquest/m2/recut-held.md's Goal, leavingapi-audit,drop-set,rind, andstream-creditintact.
I verified there are no remaining session-policy references anywhere in the repo, and spot-checked the goal-audit claims against source: Server::deadline / Accept::with_deadline / Handshake::poll_expired / with_receive_window in rs/moq-net/src/server.rs, Reconnect / Action::Abandon in rs/moq-net/src/reconnect.rs, the set_limits transport hook in rs/moq-net/src/transport/boxed.rs, and connect_with / accept_with in rs/moq-webrtc/src/p2p/mod.rs:379,480. The epic is genuinely finished and the deletion is consistent across every doc that referenced it.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
|
quest land watch: the merge queue removed this pull request at 6c3d11b because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |
Finishes quest/m1/session-policy/README.md. Every child already landed, and the last clause of the Goal ("done when the WebRTC transport's session runs through the same policy") landed with moq-dev/moq#8122. This PR only deletes the epic.
Summary
quest rm, which drops its links from m1's and m2'sRequired.session-policyfrom the held-epic prose inquest/m1/README.mdand from Finish the milestone re-cut's Goal, since nothing is left to move.Goal audit (
origin/mainat 619f5c8)moq_net::Server::deadline,Accept::with_deadline,Handshake::poll_expired(rs/moq-net/src/server.rs). moq-tokio'sRequest::withinonly races itmoq_net::reconnect::Reconnectpoll machine (rs/moq-net/src/reconnect.rs). moq-tokio'sconnection.rskeeps only CLI knobs that resolve to it, the dialer, andMonitorHandshake::with_receive_windowover the transportset_limitshook (rs/moq-net/src/transport/boxed.rs)Connectionand moq-net's accept policy (moq-dev/moq#8082); moq-uring has no client sidep2p::Offerer::connectcallsClient::connect_withandp2p::Answerer::acceptcallsListener::accept_with(rs/moq-webrtc/src/p2p/mod.rs:379,:480)Choices made without asking
Client::connect_with(rs/moq-tokio/src/client.rs:331) bounds the MoQ handshake with akio::clock::timeoutofreconnect::Config::timeoutin moq-tokio, rather than a deadline owned bymoq_net::Client::connect. I counted this as finished, not leftover work: the value comes from moq-net's policy, the error matches the reconnect path's (Error::ConnectTimeout), and a client giving up on a handshake has no close code to send, the same wayReconnect'sAction::Abandonjust drops the dial. AddingConnect::with_deadlineto moq-net would be a new public surface whose only consumer replaces six lines.Public API
None. Wire: none.
Validation
quest check --base origin/main: ok (584 documents).cargo test -p moq-webrtc --features p2p --lib p2p: 22 passed, includingsession_over_loopback,zero_timeout_is_unbounded, anda_drain_waits_for_an_establishing_peer, which exercise the handoffs.Review
mechanical fix by quest land watch:
merged main at 738c82bfbb93fe3bf6ba45a0e09a03203b895fd9 with the quest merge driver(head 549a6ea)Round 1:
quest reviewwith Codex, gpt-6.1-sol at medium effort, on head6c3d11bdc7a8ad767868434b680fb7cbaaee3b6fagainstorigin/mainat619f5c8b3f. No findings.Follow-ups
None.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)